You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/07/02 12:11:11 UTC
[GitHub] [cordova-plugin-file] timbru31 opened a new pull request #406: WIP: chore: adds package-lock file
timbru31 opened a new pull request #406:
URL: https://github.com/apache/cordova-plugin-file/pull/406
### Motivation and Context
Consistency of our codebases. part of https://github.com/apache/cordova/issues/4. Depends on #405
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-file] timbru31 commented on pull request #406: WIP: chore: adds package-lock file
Posted by GitBox <gi...@apache.org>.
timbru31 commented on pull request #406:
URL: https://github.com/apache/cordova-plugin-file/pull/406#issuecomment-735403181
Because the lock file include the dependencies of the `@cordova/eslint-config` package. I'll try to see what's the state of #405 next week 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-file] breautek commented on pull request #406: WIP: chore: adds package-lock file
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #406:
URL: https://github.com/apache/cordova-plugin-file/pull/406#issuecomment-735754012
> Because the lock file include the dependencies of the `@cordova/eslint-config` package. I'll try to see what's the state of #405 next week
I see. I'll be merging #442 which does not have the same dependency, but I'll update it to not close this PR since it's still valid... or maybe #405 can be rebased to include the `package-lock.json` change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-file] breautek commented on pull request #406: WIP: chore: adds package-lock file
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #406:
URL: https://github.com/apache/cordova-plugin-file/pull/406#issuecomment-734992930
Why does this depend on #405?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org