You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/29 19:42:15 UTC

[GitHub] [flink] zentol opened a new pull request #14522: [FLINK-20807][build] Remove/narrow various checkstyle suppressions

zentol opened a new pull request #14522:
URL: https://github.com/apache/flink/pull/14522


   A whole bunch of checkstyle suppressions are no longer necessary, or could be narrowed down to single files.
   So I did just that.
   
   This was an interesting exercise in which parts are applied by spotless, and which still require checkstyle to be active.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14522: [FLINK-20807][build] Remove/narrow various checkstyle suppressions

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14522:
URL: https://github.com/apache/flink/pull/14522#issuecomment-752218880


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit aeed106994e81ece4c448c12ac0951407f562916 (Tue Dec 29 19:44:24 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14522: [FLINK-20807][build] Remove/narrow various checkstyle suppressions

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14522:
URL: https://github.com/apache/flink/pull/14522#issuecomment-752223079


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "aeed106994e81ece4c448c12ac0951407f562916",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "aeed106994e81ece4c448c12ac0951407f562916",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * aeed106994e81ece4c448c12ac0951407f562916 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol merged pull request #14522: [FLINK-20807][build] Remove/narrow various checkstyle suppressions

Posted by GitBox <gi...@apache.org>.
zentol merged pull request #14522:
URL: https://github.com/apache/flink/pull/14522


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14522: [FLINK-20807][build] Remove/narrow various checkstyle suppressions

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14522:
URL: https://github.com/apache/flink/pull/14522#issuecomment-752223079


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "aeed106994e81ece4c448c12ac0951407f562916",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11473",
       "triggerID" : "aeed106994e81ece4c448c12ac0951407f562916",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * aeed106994e81ece4c448c12ac0951407f562916 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11473) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14522: [FLINK-20807][build] Remove/narrow various checkstyle suppressions

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14522:
URL: https://github.com/apache/flink/pull/14522#issuecomment-752223079


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "aeed106994e81ece4c448c12ac0951407f562916",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11473",
       "triggerID" : "aeed106994e81ece4c448c12ac0951407f562916",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * aeed106994e81ece4c448c12ac0951407f562916 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11473) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14522: [FLINK-20807][build] Remove/narrow various checkstyle suppressions

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14522:
URL: https://github.com/apache/flink/pull/14522#issuecomment-752218880


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit aeed106994e81ece4c448c12ac0951407f562916 (Fri May 28 06:58:40 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org