You are viewing a plain text version of this content. The canonical link for it is here.

Posted to hdfs-issues@hadoop.apache.org by "Ravi Prakash (JIRA)" <ji...@apache.org> on 2014/10/24 21:08:34 UTC

[jira] [Updated] (HDFS-7287) The OfflineImageViewer (OIV) can output invalid XML depending on the filename

     [ https://issues.apache.org/jira/browse/HDFS-7287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ravi Prakash updated HDFS-7287:
-------------------------------
    Attachment: HDFS-7287.patch

Words of warning:
1. I am *adding* apache.commons.lang3 to the list of dependencies for hadoop-hdfs
2. StringEscapeUtils.escapeXml10 is slowing down OIV considerably. A file which used to take 10 seconds is now taking 50 seconds. LANG-877 talks about performance improvements for StringUtils, but to me this is a correctness issue

> The OfflineImageViewer (OIV) can output invalid XML depending on the filename
> -----------------------------------------------------------------------------
>
>                 Key: HDFS-7287
>                 URL: https://issues.apache.org/jira/browse/HDFS-7287
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.0.0-alpha
>            Reporter: Ravi Prakash
>         Attachments: HDFS-7287.patch
>
>
> If the filename contains a character which is invalid in XML, TextWriterImageVisitor.write() or PBImageXmlWriter.o() prints out the string unescaped. For us this was the character 0x0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)