You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/08/13 23:53:14 UTC
Review Request 24673: Used new CommandInfo with Docker::run.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24673/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Timothy Chen.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571
Diff: https://reviews.apache.org/r/24673/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 24673: Used new CommandInfo with Docker::run.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24673/#review50558
-----------------------------------------------------------
Bad patch!
Reviews applied: [24673]
Failed command: git apply --index 24673.patch
Error:
error: patch failed: src/docker/docker.cpp:263
error: src/docker/docker.cpp: patch does not apply
- Mesos ReviewBot
On Aug. 13, 2014, 9:53 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24673/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2014, 9:53 p.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571
>
> Diff: https://reviews.apache.org/r/24673/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24673: Used new CommandInfo with Docker::run.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Aug. 13, 2014, 10:20 p.m., Jie Yu wrote:
> > src/docker/docker.cpp, line 266
> > <https://reviews.apache.org/r/24673/diff/1/?file=659614#file659614line266>
> >
> > I would probably rename it to argv as subprocess's signature uses argv.
Great idea! Thanks Jie!
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24673/#review50519
-----------------------------------------------------------
On Aug. 13, 2014, 9:53 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24673/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2014, 9:53 p.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571
>
> Diff: https://reviews.apache.org/r/24673/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24673: Used new CommandInfo with Docker::run.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24673/#review50519
-----------------------------------------------------------
Ship it!
src/docker/docker.cpp
<https://reviews.apache.org/r/24673/#comment88380>
I would probably rename it to argv as subprocess's signature uses argv.
- Jie Yu
On Aug. 13, 2014, 9:53 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24673/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2014, 9:53 p.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571
>
> Diff: https://reviews.apache.org/r/24673/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24673: Used new CommandInfo with Docker::run.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Aug. 13, 2014, 10:22 p.m., Timothy Chen wrote:
> > Ship It!
>
> Timothy Chen wrote:
> Ben you will need to update this rb with the new commandInfo argv -> arguments renamed.
Yup, done, thanks.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24673/#review50520
-----------------------------------------------------------
On Aug. 13, 2014, 9:53 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24673/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2014, 9:53 p.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571
>
> Diff: https://reviews.apache.org/r/24673/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24673: Used new CommandInfo with Docker::run.
Posted by Timothy Chen <tn...@apache.org>.
> On Aug. 13, 2014, 10:22 p.m., Timothy Chen wrote:
> > Ship It!
Ben you will need to update this rb with the new commandInfo argv -> arguments renamed.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24673/#review50520
-----------------------------------------------------------
On Aug. 13, 2014, 9:53 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24673/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2014, 9:53 p.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571
>
> Diff: https://reviews.apache.org/r/24673/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24673: Used new CommandInfo with Docker::run.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24673/#review50520
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Aug. 13, 2014, 9:53 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24673/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2014, 9:53 p.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571
>
> Diff: https://reviews.apache.org/r/24673/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>