You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "brbzull0 (via GitHub)" <gi...@apache.org> on 2024/12/12 13:46:52 UTC

[PR] Coverity. `swoc` Make Name Binding global variables a singleton. [trafficserver]

brbzull0 opened a new pull request, #11908:
URL: https://github.com/apache/trafficserver/pull/11908

   This is an attempt to fix some ordering creation issues for some global variables within  lib swoc. 
   The is to get `swoc::bwf::Global_Names` initialized first.
   
   One of many Coverity issues [#1534740](https://scan6.scan.coverity.com/#/project-view/58063/10191?selectedIssue=1534740)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Coverity. `swoc` Make Name Binding global variables a singleton. [trafficserver]

Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on PR #11908:
URL: https://github.com/apache/trafficserver/pull/11908#issuecomment-2589461203

   [approve ci rocky]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Coverity. `swoc` Make Name Binding global variables a singleton. [trafficserver]

Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #11908:
URL: https://github.com/apache/trafficserver/pull/11908#issuecomment-2593484640

   Cherry-picked to v10.0.x


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Coverity. `swoc` Make Name Binding global variables a singleton. [trafficserver]

Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on PR #11908:
URL: https://github.com/apache/trafficserver/pull/11908#issuecomment-2541466146

   `fedora` is failing because it uses an external `libswoc`.
   
   @bneradt  what do you think? should I patch `libswoc` repo first in this case?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Coverity. `swoc` Make Name Binding global variables a singleton. [trafficserver]

Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on code in PR #11908:
URL: https://github.com/apache/trafficserver/pull/11908#discussion_r1909525637


##########
lib/swoc/include/swoc/bwf_base.h:
##########
@@ -467,7 +467,7 @@ template <typename T> class ContextNames : public NameMap<BufferWriter &(BufferW
  * This nameset is used if no other is provided. Therefore bindings added to this nameset will be
  * available in the default formatting use.
  */
-extern ExternalNames Global_Names;
+extern ExternalNames& Global_Names();

Review Comment:
   You can drop `extern` here since its a function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Coverity. `swoc` Make Name Binding global variables a singleton. [trafficserver]

Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on PR #11908:
URL: https://github.com/apache/trafficserver/pull/11908#issuecomment-2541361280

   @bneradt you think we should patch `libswoc` first?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Coverity. `swoc` Make Name Binding global variables a singleton. [trafficserver]

Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on PR #11908:
URL: https://github.com/apache/trafficserver/pull/11908#issuecomment-2539084756

   [approve ci debian]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Coverity. `swoc` Make Name Binding global variables a singleton. [trafficserver]

Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on PR #11908:
URL: https://github.com/apache/trafficserver/pull/11908#issuecomment-2541071025

   `rocky` issue here is that ci is using an external libswoc and this changes the library objects, so it fails.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Coverity. `swoc` Make Name Binding global variables a singleton. [trafficserver]

Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on PR #11908:
URL: https://github.com/apache/trafficserver/pull/11908#issuecomment-2541072026

   [approve autest 1]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Coverity. `swoc` Make Name Binding global variables a singleton. [trafficserver]

Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #11908:
URL: https://github.com/apache/trafficserver/pull/11908#issuecomment-2591321184

   [approve ci rocky]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Coverity. `swoc` Make Name Binding global variables a singleton. [trafficserver]

Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt merged PR #11908:
URL: https://github.com/apache/trafficserver/pull/11908


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org