You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by sr...@apache.org on 2016/12/13 09:40:21 UTC
spark git commit: [MINOR][CORE][SQL] Remove explicit RDD and
Partition overrides
Repository: spark
Updated Branches:
refs/heads/master 46d30ac48 -> 096f868b7
[MINOR][CORE][SQL] Remove explicit RDD and Partition overrides
## What changes were proposed in this pull request?
I **believe** that I _only_ removed duplicated code (that adds nothing but noise). I'm gonna remove the comment after Jenkins has built the changes with no issues and Spark devs has agreed to include the changes.
Remove explicit `RDD` and `Partition` overrides (that turn out code duplication)
## How was this patch tested?
Local build. Awaiting Jenkins.
\u2026cation)
Author: Jacek Laskowski <ja...@japila.pl>
Closes #16145 from jaceklaskowski/rdd-overrides-removed.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/096f868b
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/096f868b
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/096f868b
Branch: refs/heads/master
Commit: 096f868b74d01c3dfc8f09e1e7dfc0ebab65226f
Parents: 46d30ac
Author: Jacek Laskowski <ja...@japila.pl>
Authored: Tue Dec 13 09:40:16 2016 +0000
Committer: Sean Owen <so...@cloudera.com>
Committed: Tue Dec 13 09:40:16 2016 +0000
----------------------------------------------------------------------
core/src/main/scala/org/apache/spark/rdd/ShuffledRDD.scala | 4 ----
.../scala/org/apache/spark/sql/execution/ShuffledRowRDD.scala | 4 ----
2 files changed, 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/096f868b/core/src/main/scala/org/apache/spark/rdd/ShuffledRDD.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/rdd/ShuffledRDD.scala b/core/src/main/scala/org/apache/spark/rdd/ShuffledRDD.scala
index 29d5d74..26eaa9a 100644
--- a/core/src/main/scala/org/apache/spark/rdd/ShuffledRDD.scala
+++ b/core/src/main/scala/org/apache/spark/rdd/ShuffledRDD.scala
@@ -25,10 +25,6 @@ import org.apache.spark.serializer.Serializer
private[spark] class ShuffledRDDPartition(val idx: Int) extends Partition {
override val index: Int = idx
-
- override def hashCode(): Int = index
-
- override def equals(other: Any): Boolean = super.equals(other)
}
/**
http://git-wip-us.apache.org/repos/asf/spark/blob/096f868b/sql/core/src/main/scala/org/apache/spark/sql/execution/ShuffledRowRDD.scala
----------------------------------------------------------------------
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/ShuffledRowRDD.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/ShuffledRowRDD.scala
index 5f0c264..862ee05 100644
--- a/sql/core/src/main/scala/org/apache/spark/sql/execution/ShuffledRowRDD.scala
+++ b/sql/core/src/main/scala/org/apache/spark/sql/execution/ShuffledRowRDD.scala
@@ -33,10 +33,6 @@ private final class ShuffledRowRDDPartition(
val startPreShufflePartitionIndex: Int,
val endPreShufflePartitionIndex: Int) extends Partition {
override val index: Int = postShufflePartitionIndex
-
- override def hashCode(): Int = postShufflePartitionIndex
-
- override def equals(other: Any): Boolean = super.equals(other)
}
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org