You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/08/07 01:06:35 UTC

[GitHub] [shardingsphere-elasticjob] stanstanwang commented on pull request #1956: bugfix: getJobConfiguration return null instead of throw NullPointerException

stanstanwang commented on pull request #1956:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1956#issuecomment-894582598


   > Hi @stanstanwang
   > I think returning null is not elegant. How about throw something like `JobConfigurationException`?
   
   in my usage scenario , there is no check config exists method, so every time before i  get the config, i must catch the NullPointerException , this  is troublesome,  may be mark the method return @Nullable or using Optional is also elegant


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org