You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by mm...@apache.org on 2020/05/29 05:39:24 UTC
[pulsar] branch master updated: Brokers must advertize on localhost
to avoid problems creating client (#7067)
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 5c06756 Brokers must advertize on localhost to avoid problems creating client (#7067)
5c06756 is described below
commit 5c0675687e8c98904d6ce9b563b43f1d8044410f
Author: Matteo Merli <mm...@apache.org>
AuthorDate: Thu May 28 22:39:09 2020 -0700
Brokers must advertize on localhost to avoid problems creating client (#7067)
This works around the issue where if the hostname of the machine has an underscore,
the test will fail to run
Co-authored-by: Ivan Kelly <ik...@splunk.com>
---
.../pulsar/broker/loadbalance/AntiAffinityNamespaceGroupTest.java | 1 +
.../apache/pulsar/broker/loadbalance/SimpleLoadManagerImplTest.java | 1 +
.../java/org/apache/pulsar/broker/service/PersistentTopicTest.java | 1 +
.../src/test/java/org/apache/pulsar/io/PulsarFunctionTlsTest.java | 3 ++-
4 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/AntiAffinityNamespaceGroupTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/AntiAffinityNamespaceGroupTest.java
index 229ee84..8cb4e0a 100644
--- a/pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/AntiAffinityNamespaceGroupTest.java
+++ b/pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/AntiAffinityNamespaceGroupTest.java
@@ -129,6 +129,7 @@ public class AntiAffinityNamespaceGroupTest {
config2.setZookeeperServers("127.0.0.1" + ":" + bkEnsemble.getZookeeperPort());
config2.setBrokerServicePort(Optional.of(0));
config2.setFailureDomainsEnabled(true);
+ config2.setAdvertisedAddress("localhost");
pulsar2 = new PulsarService(config2);
pulsar2.start();
diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/SimpleLoadManagerImplTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/SimpleLoadManagerImplTest.java
index 999987b..68cf478 100644
--- a/pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/SimpleLoadManagerImplTest.java
+++ b/pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/SimpleLoadManagerImplTest.java
@@ -145,6 +145,7 @@ public class SimpleLoadManagerImplTest {
config2.setLoadManagerClassName(SimpleLoadManagerImpl.class.getName());
config2.setBrokerServicePortTls(Optional.of(0));
config2.setWebServicePortTls(Optional.of(0));
+ config2.setAdvertisedAddress("localhost");
pulsar2 = new PulsarService(config2);
pulsar2.start();
diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentTopicTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentTopicTest.java
index 3c66d92..ae0bd4d 100644
--- a/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentTopicTest.java
+++ b/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentTopicTest.java
@@ -159,6 +159,7 @@ public class PersistentTopicTest extends MockedBookKeeperTestCase {
public void setup() throws Exception {
executor = OrderedExecutor.newBuilder().numThreads(1).build();
ServiceConfiguration svcConfig = spy(new ServiceConfiguration());
+ svcConfig.setAdvertisedAddress("localhost");
pulsar = spy(new PulsarService(svcConfig));
doReturn(svcConfig).when(pulsar).getConfiguration();
doReturn(mock(Compactor.class)).when(pulsar).getCompactor();
diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/io/PulsarFunctionTlsTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/io/PulsarFunctionTlsTest.java
index ed7a0dd..ed33614 100644
--- a/pulsar-broker/src/test/java/org/apache/pulsar/io/PulsarFunctionTlsTest.java
+++ b/pulsar-broker/src/test/java/org/apache/pulsar/io/PulsarFunctionTlsTest.java
@@ -116,6 +116,7 @@ public class PulsarFunctionTlsTest {
config.setTlsCertificateFilePath(TLS_SERVER_CERT_FILE_PATH);
config.setTlsKeyFilePath(TLS_SERVER_KEY_FILE_PATH);
config.setTlsAllowInsecureConnection(true);
+ config.setAdvertisedAddress("localhost");
functionsWorkerService = spy(createPulsarFunctionWorker(config));
AuthenticationService authenticationService = new AuthenticationService(config);
AuthorizationService authorizationService = new AuthorizationService(config, mock(ConfigurationCacheService.class));
@@ -260,4 +261,4 @@ public class PulsarFunctionTlsTest {
return functionConfig;
}
-}
\ No newline at end of file
+}