You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "sharmaar12 (via GitHub)" <gi...@apache.org> on 2026/04/09 11:53:13 UTC
[PR] HBASE-30069:Instead of generic DoNotRetryIOException send specific Exception [hbase]
sharmaar12 opened a new pull request, #8049:
URL: https://github.com/apache/hbase/pull/8049
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-30069:Instead of generic DoNotRetryIOException send specific Exception [hbase]
Posted by "sharmaar12 (via GitHub)" <gi...@apache.org>.
sharmaar12 commented on code in PR #8049:
URL: https://github.com/apache/hbase/pull/8049#discussion_r3058044825
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestReadOnlyControllerBulkLoadObserver.java:
##########
@@ -58,12 +58,12 @@ public void tearDown() throws Exception {
}
- @Test(expected = DoNotRetryIOException.class)
+ @Test(expected = WriteAttemptedOnReadOnlyClusterException.class)
Review Comment:
@vaijosh Noted. I will create another PR for HBASE-29081 branch and do the changes there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-30069:Instead of generic DoNotRetryIOException send specific Exception [hbase]
Posted by "anmolnar (via GitHub)" <gi...@apache.org>.
anmolnar commented on PR #8049:
URL: https://github.com/apache/hbase/pull/8049#issuecomment-4214465059
@sharmaar12 Please use the original `HBASE-29081` branch for pull requests going forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-30069:Instead of generic DoNotRetryIOException send specific Exception [hbase]
Posted by "sharmaar12 (via GitHub)" <gi...@apache.org>.
sharmaar12 closed pull request #8049: HBASE-30069:Instead of generic DoNotRetryIOException send specific Exception
URL: https://github.com/apache/hbase/pull/8049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-30069:Instead of generic DoNotRetryIOException send specific Exception [hbase]
Posted by "vaijosh (via GitHub)" <gi...@apache.org>.
vaijosh commented on code in PR #8049:
URL: https://github.com/apache/hbase/pull/8049#discussion_r3057894170
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestReadOnlyControllerBulkLoadObserver.java:
##########
@@ -58,12 +58,12 @@ public void tearDown() throws Exception {
}
- @Test(expected = DoNotRetryIOException.class)
+ @Test(expected = WriteAttemptedOnReadOnlyClusterException.class)
Review Comment:
Hi @sharmaar12
Since we’ve migrated to JUnit 5, we should move away from the outdated expected parameter in the @Test annotation. Please use assertThrows instead. Additionally, the current tests don't verify the exception message—using assertThrows will allow you to capture the exception and assert against the message. While the old pattern might work for legacy branches, we need to follow the new standard for any merges into master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org