You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/10/26 12:14:54 UTC
Review Request 39651: LENS-845: Add Driver level UDF rename
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39651/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-845
https://issues.apache.org/jira/browse/LENS-845
Repository: lens
Description
-------
Diffs
-----
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java c6797aa441cf160d45cda74a7ccf9facd3084488
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java a26acde14c3f71c60cacb9e99290827eb82f5525
lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml e94c2f35f998796dd6e40d440db75305c56b9f1d
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 31c7dadec795141769d12448c9381a6a73482f61
Diff: https://reviews.apache.org/r/39651/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 39651: LENS-845: Take regex rename arguments in
columnar sql rewriter
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Oct. 26, 2015, 5:03 p.m., Amareshwari Sriramadasu wrote:
> > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java, line 137
> > <https://reviews.apache.org/r/39651/diff/1/?file=1107551#file1107551line137>
> >
> > Is this required?
Yes. The hardcoded values have been moved to default conf. Loading that here.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39651/#review103996
-----------------------------------------------------------
On Oct. 26, 2015, 5:56 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39651/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2015, 5:56 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-845
> https://issues.apache.org/jira/browse/LENS-845
>
>
> Repository: lens
>
>
> Description
> -------
>
> right now, the replacement strings are hard coded.
>
>
> Diffs
> -----
>
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java c6797aa441cf160d45cda74a7ccf9facd3084488
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java a26acde14c3f71c60cacb9e99290827eb82f5525
> lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml e94c2f35f998796dd6e40d440db75305c56b9f1d
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 31c7dadec795141769d12448c9381a6a73482f61
> lens-driver-jdbc/src/test/resources/jdbcdriver-site.xml 1dc0a85b485232ebb3513f910899d34323042605
>
> Diff: https://reviews.apache.org/r/39651/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 39651: LENS-845: Take regex rename arguments in
columnar sql rewriter
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39651/#review103996
-----------------------------------------------------------
lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml (line 38)
<https://reviews.apache.org/r/39651/#comment162184>
Can you override this in tests to take more mapping and a test for new mapping provided ?
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java (line 137)
<https://reviews.apache.org/r/39651/#comment162183>
Is this required?
- Amareshwari Sriramadasu
On Oct. 26, 2015, 11:16 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39651/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2015, 11:16 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-845
> https://issues.apache.org/jira/browse/LENS-845
>
>
> Repository: lens
>
>
> Description
> -------
>
> right now, the replacement strings are hard coded.
>
>
> Diffs
> -----
>
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java c6797aa441cf160d45cda74a7ccf9facd3084488
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java a26acde14c3f71c60cacb9e99290827eb82f5525
> lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml e94c2f35f998796dd6e40d440db75305c56b9f1d
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 31c7dadec795141769d12448c9381a6a73482f61
>
> Diff: https://reviews.apache.org/r/39651/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 39651: LENS-845: Take regex rename arguments in
columnar sql rewriter
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39651/#review104001
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Oct. 26, 2015, 12:26 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39651/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2015, 12:26 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-845
> https://issues.apache.org/jira/browse/LENS-845
>
>
> Repository: lens
>
>
> Description
> -------
>
> right now, the replacement strings are hard coded.
>
>
> Diffs
> -----
>
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java c6797aa441cf160d45cda74a7ccf9facd3084488
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java a26acde14c3f71c60cacb9e99290827eb82f5525
> lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml e94c2f35f998796dd6e40d440db75305c56b9f1d
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 31c7dadec795141769d12448c9381a6a73482f61
> lens-driver-jdbc/src/test/resources/jdbcdriver-site.xml 1dc0a85b485232ebb3513f910899d34323042605
>
> Diff: https://reviews.apache.org/r/39651/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 39651: LENS-845: Take regex rename arguments in
columnar sql rewriter
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39651/
-----------------------------------------------------------
(Updated Oct. 26, 2015, 5:56 p.m.)
Review request for lens.
Bugs: LENS-845
https://issues.apache.org/jira/browse/LENS-845
Repository: lens
Description
-------
right now, the replacement strings are hard coded.
Diffs (updated)
-----
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java c6797aa441cf160d45cda74a7ccf9facd3084488
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java a26acde14c3f71c60cacb9e99290827eb82f5525
lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml e94c2f35f998796dd6e40d440db75305c56b9f1d
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 31c7dadec795141769d12448c9381a6a73482f61
lens-driver-jdbc/src/test/resources/jdbcdriver-site.xml 1dc0a85b485232ebb3513f910899d34323042605
Diff: https://reviews.apache.org/r/39651/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 39651: LENS-845: Take regex rename arguments in
columnar sql rewriter
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39651/
-----------------------------------------------------------
(Updated Oct. 26, 2015, 4:46 p.m.)
Review request for lens.
Summary (updated)
-----------------
LENS-845: Take regex rename arguments in columnar sql rewriter
Bugs: LENS-845
https://issues.apache.org/jira/browse/LENS-845
Repository: lens
Description (updated)
-------
right now, the replacement strings are hard coded.
Diffs
-----
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java c6797aa441cf160d45cda74a7ccf9facd3084488
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java a26acde14c3f71c60cacb9e99290827eb82f5525
lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml e94c2f35f998796dd6e40d440db75305c56b9f1d
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 31c7dadec795141769d12448c9381a6a73482f61
Diff: https://reviews.apache.org/r/39651/diff/
Testing
-------
Thanks,
Rajat Khandelwal