You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/06/23 13:27:20 UTC
[GitHub] [cloudstack] DK101010 opened a new pull request #5148: Bug/false positive success message vm start
DK101010 opened a new pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148
### Description
During the start vm command, cs notify user that vm started successfully, but wasn't.
In our case, it occurred when a host crashed and cs did not notice.
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Own VMware env.
Shutdown host in the VCenter and try to start a VM on this host in CS.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#issuecomment-867869026
<b>Trillian test result (tid-1083)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38598 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5148-t1083-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 87 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#issuecomment-868259811
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#issuecomment-867349001
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#issuecomment-867406766
@rhtyd I have now tested it with the host switched off. The same behaviour as with maintenance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#issuecomment-869082606
Lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#issuecomment-867388517
> Hi @DK101010 ideally it may not completely be a CloudStack bug if infra is marked in maintenance in vcenter but not in CloudStack. What you're suggesting may be a new feature or enhancement to track host maintenance state on vCenter. Can you test if say instead of putting host in maintenance on vCenter side, check how CloudStack behaves if you really simulate to crash the host, say power off the host?
hmm ... I will test this behavior by shutting down the host.
In normal case when we use CS than we should control host maintenance over CS. But you are right, is a nice idea, this feature makes the code safer from human interference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#discussion_r657372616
##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/cloud/entity/api/VMEntityManagerImpl.java
##########
@@ -253,6 +253,8 @@ public void deployVirtualMachine(String reservationId, VMEntityVO vmEntityVO, St
}
_itMgr.start(vm.getUuid(), params, plan, null);
+ }else{
Review comment:
Can you please adjust the formation from `}else{` to `} else {`?
##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/cloud/entity/api/VMEntityManagerImpl.java
##########
@@ -253,6 +253,8 @@ public void deployVirtualMachine(String reservationId, VMEntityVO vmEntityVO, St
}
_itMgr.start(vm.getUuid(), params, plan, null);
+ }else{
+ throw ex;
Review comment:
I would recommend presenting more details to the user/admin. A message that gives some context (where/how) regarding this exception could help the caller to understand what is going on.
For instance:
`
throw new ResourceUnavailableException(String.format("message containing details of issue for VM %s", vm));
`
OR
`
throw new ResourceUnavailableException(String.format("message containing details of issue for VM %s due to exception: %s", vm, ex));
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#issuecomment-868996474
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#issuecomment-867409464
Tentatively assigned to 4.15.1 subject to review, testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#issuecomment-867408885
Thanks for testing and sharing your findings @DK101010, let me help kick the tests on this
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#issuecomment-867369049
Hi @DK101010 ideally it may completely be a CloudStack bug if infra is marked in maintenance in vcenter but not in CloudStack. What your suggesting may be a new feature or enhancement to track host maintenance state on vCenter. Can you test if say instead of putting host in maintenance on vCenter side, check how CloudStack behaves if you really simulate to crash the host, say power off the host?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 removed a comment on pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
DK101010 removed a comment on pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#issuecomment-867366119
> edge case
I'am not pretty sure what do you mean with edge case. In our case the error occurs when the host crashed and CS tries to start a vm on this host. I was able to reproduce the error by setting the host in the VCenter to maintenance. But I can not say in which cases also the problem occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#issuecomment-868996422
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#issuecomment-868210484
<b>Trillian test result (tid-1085)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 75650 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5148-t1085-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 81 look OK, 6 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3614.05 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 161.42 | test_kubernetes_clusters.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 385.81 | test_routers_network_ops.py
test_04_change_offering_small | `Failure` | 787.78 | test_service_offerings.py
test_01_create_volume | `Failure` | 670.24 | test_volumes.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 568.89 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 480.74 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 536.60 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 579.04 | test_vpc_redundant.py
test_01_cancel_host_maintenace_with_no_migration_jobs | `Failure` | 29.55 | test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs | `Failure` | 180.56 | test_host_maintenance.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#issuecomment-867351185
Is that an edge case how do we reproduce and test this issue and fix? @DK101010
cc @DaanHoogland @sureshanaparti @nvazquez
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#issuecomment-869070989
<b>Trillian test result (tid-1116)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35094 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5148-t1116-vmware-67u3.zip
Smoke tests completed. 87 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on a change in pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
DK101010 commented on a change in pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#discussion_r657645406
##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/cloud/entity/api/VMEntityManagerImpl.java
##########
@@ -253,6 +253,8 @@ public void deployVirtualMachine(String reservationId, VMEntityVO vmEntityVO, St
}
_itMgr.start(vm.getUuid(), params, plan, null);
+ }else{
Review comment:
@GabrielBrascher sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#discussion_r657736804
##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/cloud/entity/api/VMEntityManagerImpl.java
##########
@@ -253,6 +253,8 @@ public void deployVirtualMachine(String reservationId, VMEntityVO vmEntityVO, St
}
_itMgr.start(vm.getUuid(), params, plan, null);
+ }else{
Review comment:
```suggestion
} else {
```
##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/cloud/entity/api/VMEntityManagerImpl.java
##########
@@ -253,6 +253,8 @@ public void deployVirtualMachine(String reservationId, VMEntityVO vmEntityVO, St
}
_itMgr.start(vm.getUuid(), params, plan, null);
+ }else{
+ throw ex;
Review comment:
@GabrielBrascher, I tend to agree with @DK101010 but would it make sense to cature the exception in a CloudStackException saying that we are "not retrying as no host is given" ? and would that satisfy your requirements?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#discussion_r658236208
##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/cloud/entity/api/VMEntityManagerImpl.java
##########
@@ -253,6 +253,8 @@ public void deployVirtualMachine(String reservationId, VMEntityVO vmEntityVO, St
}
_itMgr.start(vm.getUuid(), params, plan, null);
+ }else{
+ throw ex;
Review comment:
@DaanHoogland @DK101010, I agree that my suggestion might be a bit too much info for this context.
As long as we don't throw raw exceptions at the user's face I am good with it :slightly_smiling_face:.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#issuecomment-867881248
<b>Trillian test result (tid-1084)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38587 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5148-t1084-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 87 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on a change in pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
DK101010 commented on a change in pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#discussion_r657649570
##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/cloud/entity/api/VMEntityManagerImpl.java
##########
@@ -253,6 +253,8 @@ public void deployVirtualMachine(String reservationId, VMEntityVO vmEntityVO, St
}
_itMgr.start(vm.getUuid(), params, plan, null);
+ }else{
+ throw ex;
Review comment:
@GabrielBrascher Maybe I'am wrong but I think is a little bit to much info, the vm is not the problem in that case. Also throws the _itMgr.start method a couple exception, so that we can not say here when the vm the problem is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#issuecomment-868259682
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#issuecomment-867348789
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#issuecomment-867372224
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#issuecomment-867409070
@rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#issuecomment-867366119
> edge case
I'am not pretty sure what do you mean with edge case. In our case the error occurs when the host crashed and CS tries to start a vm on this host. I was able to reproduce the error by setting the host in the VCenter to maintenance. But I can not say in which cases also the problem occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#issuecomment-867369342
> Is that an edge case how do we reproduce and test this issue and fix? @DK101010
> cc @DaanHoogland @sureshanaparti @nvazquez
I'm not pretty sure what do you mean with edge case. In our case the error occurs when the host is crashed and CS tries to start a vm on this host. I was able to reproduce the error by setting the host in the VCenter to maintenance. But I can not say in which cases the error also occurs. I guess every exception will be ignored that this catch block catches and deployOnHost is true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#issuecomment-868861374
<b>Trillian test result (tid-1096)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 55512 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5148-t1096-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 82 look OK, 5 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_reboot_router | `Failure` | 503.25 | test_network.py
test_change_service_offering_for_vm_with_snapshots | `Failure` | 907.32 | test_vm_snapshots.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 650.26 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 595.12 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 30.12 | test_vpc_redundant.py
test_01_redundant_vpc_site2site_vpn | `Failure` | 403.99 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | `Failure` | 116.64 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | `Error` | 117.71 | test_vpc_vpn.py
test_03_cancel_host_maintenace_with_migration_jobs_failure | `Failure` | 46.85 | test_host_maintenance.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #5148: Bug/false positive success message vm start
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#issuecomment-867369049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org