You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2021/01/18 13:46:06 UTC
[GitHub] [guacamole-client] madmath03 commented on pull request #470: GUACAMOLE-124: Add full-screen action
madmath03 commented on pull request #470:
URL: https://github.com/apache/guacamole-client/pull/470#issuecomment-762260670
@necouchman thanks for the feedback. I was really expecting this before doing any further modifications to this PR 😃
> you've added it to the Guacamole menu where it displayed either here in the hidden menu or in the menu on the home screen, I'm guessing? So that someone can go to the menu on the home screen and put the entire screen in fullscreen mode, and then start a connection?
Yes, that's exactly what I had in mind and the reason why I'm not too much of a fan of making it connection-specific.
> I guess I'm not opposed to having this functionality available on the Home screen, assuming we can agree on the correct place for it.
In that case, how and where should it be placed ?
> * It _is_ still possible to put the browser into fullscreen mode without this option in the menu on the Home screen - most browsers have both a menu item and a shortcut key (F11 or F12, I think) that trigger fullscreen mode.
That's only true for desktop browsers. I developped this PR when I was testing Guacamole on an Android tablet: it worked fine, but there is no way on tablets or smartphones to switch to Fullscreen making it not really practical...
Since the fullscreen API still works on mobile, it's just that there is no menu or shortcut for it, this PR would be really nice.
BTW: another solution but much more complicated would be to make Guacamole into a [PWA](https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps) (basically requires HTTPS, manifest.json and a Service Worker) so that we could install Guacamole and run it in fullscreen by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org