You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/07 21:16:54 UTC

[GitHub] [tvm] StrongerXi commented on issue #10265: [Bug] Default TypeMutator creates a new Global Type Var but the type checker relies on pointer equality

StrongerXi commented on issue #10265:
URL: https://github.com/apache/tvm/issues/10265#issuecomment-1306203677

   Any update on this?
   
   I feel like returning the global type var unmodified might make the semantics a bit unintuitive, because we always construct new ones for [other base types](https://github.com/apache/tvm/blob/9f7f4c6d1fcc88fb1649a295e75577eaae50bbed/python/tvm/relay/type_functor.py#L158-L165).
   
   > Alternatively, we shouldn't use pointer equality for global type vars.
   
   If this approach sounds good, I wouldn't mind giving it a shot.
   
   Could you also send a quick repro for the type checking error you are describing, if possible?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org