[GitHub] [spark] karenfeng commented on a change in pull request #33309: [SPARK-36106][SQL][CORE] Label error classes for subset of QueryCompilationErrors

[GitBox <gi...@apache.org>]

karenfeng commented on a change in pull request #33309:
URL: https://github.com/apache/spark/pull/33309#discussion_r669979430



##########
File path: core/src/main/resources/error/error-classes.json
##########
@@ -11,6 +11,25 @@
     "message" : [ "Found duplicate keys '%s'" ],
     "sqlState" : "23000"
   },
+  "GROUPING_COLUMN_MISMATCH" : {
+    "message" : [ "Column of grouping (%s) can't be found in grouping columns %s" ],
+    "sqlState" : "22023"

Review comment:
       The error class README contains a section discussing SQLSTATE: https://github.com/apache/spark/blob/master/core/src/main/resources/error/README.md, including this specific rule:
   ```
   Spark does not define its own classes or subclasses.
   ```
   The SQLSTATEs are determined by consulting the SQL standard.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org