You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by "Varesh Tapadia (JIRA)" <ji...@apache.org> on 2011/07/06 11:19:16 UTC

[jira] [Created] (WINK-347) Incorrect logging in CreateInvocationParametersHandler

Incorrect logging in CreateInvocationParametersHandler
------------------------------------------------------

                 Key: WINK-347
                 URL: https://issues.apache.org/jira/browse/WINK-347
             Project: Wink
          Issue Type: Bug
          Components: Build
    Affects Versions: 1.1.3
         Environment: Development
            Reporter: Varesh Tapadia
            Priority: Minor


In CreateInvocationParametersHandler.handleRequest() method, the logging is incorrect for parameters.
            if(parameters == null) {
                logger.trace("Actual parameters list to inject is: {}", parameters); //$NON-NLS-1$
            } else {
                logger.trace("Actual parameters list to inject is: null"); //$NON-NLS-1$
            }

The condition should be reversed or the log should be exchanged.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (WINK-347) Incorrect logging in CreateInvocationParametersHandler

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WINK-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061759#comment-13061759 ] 

Hudson commented on WINK-347:
-----------------------------

Integrated in Wink-Trunk-JDK1.5 #467 (See [https://builds.apache.org/job/Wink-Trunk-JDK1.5/467/])
    WINK-347 - Applying patch from Varesh Tapadia to avoid NPE in logging statement

lresende : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1144150
Files : 
* /incubator/wink/trunk/wink-server/src/main/java/org/apache/wink/server/internal/handlers/CreateInvocationParametersHandler.java


> Incorrect logging in CreateInvocationParametersHandler
> ------------------------------------------------------
>
>                 Key: WINK-347
>                 URL: https://issues.apache.org/jira/browse/WINK-347
>             Project: Wink
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 1.1.3
>         Environment: Development
>            Reporter: Varesh Tapadia
>            Priority: Minor
>              Labels: build
>
> In CreateInvocationParametersHandler.handleRequest() method, the logging is incorrect for parameters.
>             if(parameters == null) {
>                 logger.trace("Actual parameters list to inject is: {}", parameters); //$NON-NLS-1$
>             } else {
>                 logger.trace("Actual parameters list to inject is: null"); //$NON-NLS-1$
>             }
> The condition should be reversed or the log should be exchanged.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (WINK-347) Incorrect logging in CreateInvocationParametersHandler

Posted by "Luciano Resende (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WINK-347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Luciano Resende resolved WINK-347.
----------------------------------

    Resolution: Fixed

Patch applied. Thanks Varesh Tapadia

> Incorrect logging in CreateInvocationParametersHandler
> ------------------------------------------------------
>
>                 Key: WINK-347
>                 URL: https://issues.apache.org/jira/browse/WINK-347
>             Project: Wink
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 1.1.3
>         Environment: Development
>            Reporter: Varesh Tapadia
>            Priority: Minor
>              Labels: build
>
> In CreateInvocationParametersHandler.handleRequest() method, the logging is incorrect for parameters.
>             if(parameters == null) {
>                 logger.trace("Actual parameters list to inject is: {}", parameters); //$NON-NLS-1$
>             } else {
>                 logger.trace("Actual parameters list to inject is: null"); //$NON-NLS-1$
>             }
> The condition should be reversed or the log should be exchanged.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira