You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Nigel Jones <ni...@gmail.com> on 2018/04/16 10:39:00 UTC

Review Request 66630: ATLAS-2569 maven dependency backlevel

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66630/
-----------------------------------------------------------

Review request for atlas, David Radley, Graham Wallis, and Madhan Neethiraj.


Repository: atlas


Description
-------

Old version of plugin was using maven 2 dependency algorithms, potentially leading to misleading results when checking dependency tree

[INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @ atlas-client-v1 ---
[WARNING] Using Maven 2 dependency tree to get verbose output, which may be inconsistent with actual Maven 3 resolution

I have increased the version of the plugin to 3.1.0 which appears to resolve this issue


Diffs
-----

  pom.xml a6d126818 


Diff: https://reviews.apache.org/r/66630/diff/1/


Testing
-------


Thanks,

Nigel Jones

Re: Review Request 66630: ATLAS-2569 maven dependency backlevel

Posted by Graham Wallis <gr...@uk.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66630/#review201725
-----------------------------------------------------------



+1 for the patch.

- Graham Wallis


On April 16, 2018, 10:47 a.m., Nigel Jones wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66630/
> -----------------------------------------------------------
> 
> (Updated April 16, 2018, 10:47 a.m.)
> 
> 
> Review request for atlas, David Radley, Graham Wallis, and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Old version of plugin was using maven 2 dependency algorithms, potentially leading to misleading results when checking dependency tree
> 
> [INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @ atlas-client-v1 ---
> [WARNING] Using Maven 2 dependency tree to get verbose output, which may be inconsistent with actual Maven 3 resolution
> 
> I have increased the version of the plugin to 3.1.0 which appears to resolve this issue
> 
> 
> Diffs
> -----
> 
>   pom.xml a6d126818 
> 
> 
> Diff: https://reviews.apache.org/r/66630/diff/1/
> 
> 
> Testing
> -------
> 
> * Verified dependency checks work cleanly (dependency:tree)
> * Built a full build - no apparent issues
> 
> 
> Thanks,
> 
> Nigel Jones
> 
>

Re: Review Request 66630: ATLAS-2569 maven dependency backlevel

Posted by Nigel Jones <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66630/
-----------------------------------------------------------

(Updated April 16, 2018, 11:47 a.m.)


Review request for atlas, David Radley, Graham Wallis, and Madhan Neethiraj.


Repository: atlas


Description
-------

Old version of plugin was using maven 2 dependency algorithms, potentially leading to misleading results when checking dependency tree

[INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @ atlas-client-v1 ---
[WARNING] Using Maven 2 dependency tree to get verbose output, which may be inconsistent with actual Maven 3 resolution

I have increased the version of the plugin to 3.1.0 which appears to resolve this issue


Diffs
-----

  pom.xml a6d126818 


Diff: https://reviews.apache.org/r/66630/diff/1/


Testing (updated)
-------

* Verified dependency checks work cleanly (dependency:tree)
* Built a full build - no apparent issues


Thanks,

Nigel Jones