You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2018/08/03 21:02:47 UTC
[kudu-CR] build: allow overriding of pip installation parameters
Hello Andrew Wong, Jordan Birdsell, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11116
to review the following change.
Change subject: build: allow overriding of pip installation parameters
......................................................................
build: allow overriding of pip installation parameters
This commit introduces the PIP_INSTALL_FLAGS environment variable to
build-and-test.sh which can be used to override various pip installation
behaviors. For example, you can pass "-i <URL>" so that pip uses a different
installation URL to retrieve packages.
For this to work effectively, PIP_INSTALL_FLAGS must come after all of
build-and-test.sh's pip installation flags. That's because if the same flag
is passed multiple times on the command line, the last value "wins". To make
this consistent, I modified MVN_FLAGS and GRADLE_FLAGS to behave the same.
I also copied the pytest-timeout dependency from setup.py to
requirements.txt so that "python setup.py test" won't have to download
anything if it was preceeded with "pip install -r requirements.txt". It is
possible to configure setuptools with a custom index URL instead, but the
various[1] approaches[2] involve modifying files rather than passing
command line arguments.
1. https://setuptools.readthedocs.io/en/latest/easy_install.html#configuration-files
2. https://setuptools.readthedocs.io/en/latest/setuptools.html (search for dependency_links)
Change-Id: Ib09da4bb2e2cdcbf7ea4a8ab2c1089ab46d934fb
---
M build-support/jenkins/build-and-test.sh
M python/requirements.txt
2 files changed, 37 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/11116/1
--
To view, visit http://gerrit.cloudera.org:8080/11116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib09da4bb2e2cdcbf7ea4a8ab2c1089ab46d934fb
Gerrit-Change-Number: 11116
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
[kudu-CR] build: allow overriding of pip installation parameters
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11116 )
Change subject: build: allow overriding of pip installation parameters
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib09da4bb2e2cdcbf7ea4a8ab2c1089ab46d934fb
Gerrit-Change-Number: 11116
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 06 Aug 2018 17:20:58 +0000
Gerrit-HasComments: No
[kudu-CR] build: allow overriding of pip installation parameters
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11116 )
Change subject: build: allow overriding of pip installation parameters
......................................................................
build: allow overriding of pip installation parameters
This commit introduces the PIP_INSTALL_FLAGS environment variable to
build-and-test.sh which can be used to override various pip installation
behaviors. For example, you can pass "-i <URL>" so that pip uses a different
installation URL to retrieve packages.
For this to work effectively, PIP_INSTALL_FLAGS must come after all of
build-and-test.sh's pip installation flags. That's because if the same flag
is passed multiple times on the command line, the last value "wins". To make
this consistent, I modified MVN_FLAGS and GRADLE_FLAGS to behave the same.
I also copied the pytest-timeout dependency from setup.py to
requirements.txt so that "python setup.py test" won't have to download
anything if it was preceeded with "pip install -r requirements.txt". It is
possible to configure setuptools with a custom index URL instead, but the
various[1] approaches[2] involve modifying files rather than passing
command line arguments.
1. https://setuptools.readthedocs.io/en/latest/easy_install.html#configuration-files
2. https://setuptools.readthedocs.io/en/latest/setuptools.html (search for dependency_links)
Change-Id: Ib09da4bb2e2cdcbf7ea4a8ab2c1089ab46d934fb
Reviewed-on: http://gerrit.cloudera.org:8080/11116
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M build-support/jenkins/build-and-test.sh
M python/requirements.txt
2 files changed, 37 insertions(+), 23 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib09da4bb2e2cdcbf7ea4a8ab2c1089ab46d934fb
Gerrit-Change-Number: 11116
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] build: allow overriding of pip installation parameters
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11116 )
Change subject: build: allow overriding of pip installation parameters
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib09da4bb2e2cdcbf7ea4a8ab2c1089ab46d934fb
Gerrit-Change-Number: 11116
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 06 Aug 2018 16:59:28 +0000
Gerrit-HasComments: No