You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/11/05 11:56:49 UTC
[GitHub] [iceberg] chenjunjiedada commented on a diff in pull request #5760: Core: Add minimum data sequence number to ManifestEntry
chenjunjiedada commented on code in PR #5760:
URL: https://github.com/apache/iceberg/pull/5760#discussion_r1014625952
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -439,7 +439,13 @@ private void validateNoNewDeletesForDataFiles(
if (ignoreEqualityDeletes) {
ValidationException.check(
Arrays.stream(deleteFiles)
- .noneMatch(deleteFile -> deleteFile.content() == FileContent.POSITION_DELETES),
+ .noneMatch(
+ deleteFile ->
+ (deleteFile.content() == FileContent.POSITION_DELETES
+ && deleteFile.minDataSequenceNumber() == null)
+ || (deleteFile.content() == FileContent.POSITION_DELETES
+ && deleteFile.minDataSequenceNumber() != null
+ && deleteFile.minDataSequenceNumber() <= startingSequenceNumber)),
Review Comment:
This helps filter out more delete files upon current min/max filtering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org