You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/12 22:10:49 UTC
[GitHub] [airflow] kazanzhy opened a new pull request #20240: Fix MyPy Errors for Tableau provider
kazanzhy opened a new pull request #20240:
URL: https://github.com/apache/airflow/pull/20240
Fix MyPy Errors for Tableau provider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #20240: Fix MyPy Errors for Tableau provider
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #20240:
URL: https://github.com/apache/airflow/pull/20240#discussion_r767684434
##########
File path: airflow/providers/tableau/operators/tableau.py
##########
@@ -116,9 +116,9 @@ def execute(self, context: dict) -> str:
response = method(resource_id)
- if self.method == 'refresh':
+ job_id = response.id
- job_id = response.id
+ if self.method == 'refresh':
if self.blocking_refresh:
Review comment:
This can be collapsed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #20240: Fix MyPy Errors for Tableau provider
Posted by GitBox <gi...@apache.org>.
eladkal merged pull request #20240:
URL: https://github.com/apache/airflow/pull/20240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20240: Fix MyPy Errors for Tableau provider
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20240:
URL: https://github.com/apache/airflow/pull/20240#issuecomment-992451379
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kazanzhy commented on pull request #20240: Fix MyPy Errors for Tableau provider
Posted by GitBox <gi...@apache.org>.
kazanzhy commented on pull request #20240:
URL: https://github.com/apache/airflow/pull/20240#issuecomment-991996481
If needed I can merge this small PR to other my PRS devoted to mypy errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #20240: Fix MyPy Errors for Tableau provider
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #20240:
URL: https://github.com/apache/airflow/pull/20240#discussion_r767427089
##########
File path: airflow/providers/tableau/operators/tableau.py
##########
@@ -116,6 +116,8 @@ def execute(self, context: dict) -> str:
response = method(resource_id)
+ job_id = ''
Review comment:
You can just move the assignent of response.id outside of the if.
There is no need for assigning empty string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org