[jira] [Commented] (FLINK-7130) Remove eventSerializer from NFA

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143787#comment-16143787 ] 

ASF GitHub Bot commented on FLINK-7130:
---------------------------------------

GitHub user dawidwys opened a pull request:

    https://github.com/apache/flink/pull/4610

    [FLINK-7130] Removed event serializer from NFA and SharedBuffer

    ## What is the purpose of the change
    
    * The purpose is to remove usage of event serializer from `NFA` and `SharedBuffer` classes, as it should not be used in the logic part. 
    
    
    ## Brief change log
    
    *(for example:)*
      - Removed NonDuplicatingTypeSerializer
      - Removed eventSerializer from `NFA`
      - Removed eventSerializer from `SharedBuffer`
    
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): ( / no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: ( no )
      - The runtime per-record code paths (performance sensitive): ( no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dawidwys/flink cep-remove-event-serializer

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4610.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4610
    
----
commit 1f61b2f0858506a9ff7bde47a33c8ab2b6ddbb50
Author: mtunique <oa...@gmail.com>
Date:   2017-04-13T12:22:41Z

    [FLINK-7130] Removed event serializer from NFA and SharedBuffer

----


> Remove eventSerializer from NFA
> -------------------------------
>
>                 Key: FLINK-7130
>                 URL: https://issues.apache.org/jira/browse/FLINK-7130
>             Project: Flink
>          Issue Type: Sub-task
>          Components: CEP
>            Reporter: Dawid Wysakowicz
>            Assignee: Dawid Wysakowicz
>
> Right now eventSerializer is serialized within NFA. It should be present only in NFASerializer.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)