You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Aki Sukegawa (JIRA)" <ji...@apache.org> on 2016/02/29 17:49:18 UTC

[jira] [Created] (THRIFT-3699) Fix integer limit symbol includes in Python C extension

Aki Sukegawa created THRIFT-3699:
------------------------------------

             Summary: Fix integer limit symbol includes in Python C extension
                 Key: THRIFT-3699
                 URL: https://issues.apache.org/jira/browse/THRIFT-3699
             Project: Thrift
          Issue Type: Sub-task
          Components: Python - Library
    Affects Versions: 0.10.0
            Reporter: Aki Sukegawa
            Assignee: Aki Sukegawa
             Fix For: 0.10.0


INT32_MAX etc was not included correctly
Newer GCC and Clang are permissive enough to accept them but it didn't work on our CentOS 6 image.
Rather than doing C-compatibility includes correctly, I replaced them with std::numeric_limits.

The patch also adds workaround for VC++ where std::numeric_limits does not work in a single particular place of code for some reason.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)