[GitHub] [netbeans] junichi11 opened a new pull request #1314: [NETBEANS-1696] PHP 7.4 Support

[GitBox <gi...@apache.org>]

junichi11 opened a new pull request #1314:  [NETBEANS-1696] PHP 7.4 Support
URL: https://github.com/apache/netbeans/pull/1314
 
 
   https://issues.apache.org/jira/browse/NETBEANS-1696
   
   I'm going to add changes for PHP 7.4 support to this PR. **We can merge this PR into the master branch after NetBeans 11.1 is released.**
   
   ## Typed Properties 2.0
   
   See https://wiki.php.net/rfc/typed_properties_v2
   
   - Fix ASTPHP5Parser.cup
   - Fix MarkOccurrences, GotoDeclaration, and CodeCompletion features
   - Handle unusable types(void and callable) as errors in UnusableTypesUnhandledError class to avoid complicating the grammar(cup file)
   - Add and fix unit tests
   - Fix FieldRedeclarationHintError (Add the isAnnotation() method to FieldElements)
   
   ## Spread Operator in Array Expression
   
   See https://wiki.php.net/rfc/spread_operator_for_array
   
   - Fix ASTPHP5Parser.cup
   - Add UnpackableArrayElement as a new AST node (ArrayCreation holds ArrayElements as a list, so UnpackableArrayElement extends not Expression but ArrayElement)
   - Fix PHP74UnhandledError
   - Improve code completion for const statements (There was no proper context for them, so far, so add GLOBAL_CONST_EXPRESSION and CLASS_CONST_EXPRESSION as context)
   - Add unit tests for CC, GotoDeclaration, MarkOccurrences, formatting, and parser
   
   **NOTE** The following cases are not handled in the parser as errors:
   
   - `[$a, ...$b] = [1, 2, 3];`
   - `[...42];` `[..."string"];`
   - `[...['a' => 'b']];`
   
   We can handle these in a HintError class as errors if needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists