You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "hussein-awala (via GitHub)" <gi...@apache.org> on 2023/06/08 18:35:09 UTC

[GitHub] [airflow] hussein-awala opened a new pull request, #31802: Decrease trigger ending log message level to info

hussein-awala opened a new pull request, #31802:
URL: https://github.com/apache/airflow/pull/31802

   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   closes: #31799
   
   I searched in the history about the reason to use 100 as log level, but it seems that it was just for debugging, where there is no logical need to log an error here, sine we need to stop the trigger after each run.
   
   This line was added by #29482 which restored #27758
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #31802: Decrease trigger ending log message level to info

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #31802:
URL: https://github.com/apache/airflow/pull/31802#issuecomment-1584154341

   > perhaps we should add a clarifying comment instead?
   
   Clearly we need it as none of us had a clue about it :) 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #31802: Decrease trigger ending log message level to info

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #31802:
URL: https://github.com/apache/airflow/pull/31802#issuecomment-1583147671

   I think @dstandish should have a say on this one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] hussein-awala commented on pull request #31802: Decrease trigger ending log message level to info

Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on PR #31802:
URL: https://github.com/apache/airflow/pull/31802#issuecomment-1583150258

   > I think @dstandish should have a say on this one.
   
   Indeed, I was going to mention him.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] hussein-awala closed pull request #31802: Decrease trigger ending log message level to info

Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala closed pull request #31802: Decrease trigger ending log message level to info
URL: https://github.com/apache/airflow/pull/31802


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org