[GitHub] [openwhisk-cli] giusdp opened a new pull request, #523: Add env and env-file flags for action create/update

["giusdp (via GitHub)" <gi...@apache.org>]

giusdp opened a new pull request, #523:
URL: https://github.com/apache/openwhisk-cli/pull/523

   Following the PR that adds the Env field to the action struct in client-go https://github.com/apache/openwhisk-client-go/pull/158, this PR adds the `--env` and `--env-file` flag to wsk action create/update. 
   
   It follows closely the code for the --params and --annotation flags to add support for passing environment variables during [action initialization].
   
   I tried to extend some tests in Go but let me know where I should add more.
   
   [action initialization]: https://github.com/apache/openwhisk/blob/master/docs/actions-new.md#initialization


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add env and env-file flags for action create/update [openwhisk-cli]

["kcexn (via GitHub)" <gi...@apache.org>]

kcexn commented on PR #523:
URL: https://github.com/apache/openwhisk-cli/pull/523#issuecomment-1834672503

   Can you explain to me how the environment variables are passed to the action initialization route in the action-proxy? 
   
   I thought the OpenWhisk-CLI simply sends requests to the OpenWhisk API? And as far as I can tell, the OpenWhisk API does not directly support passing environment variables to actions on initialization. Unless there is an undocumented annotation for it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org