You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@river.apache.org by Mark Brouwer <ma...@marbro.org> on 2008/06/01 23:16:33 UTC

Patches for review

Due to the large number of JIRA postings in a short timeframe, just a
note that patches for RIVER-22 and RIVER-25 have been posted.

BTW it is very hard currently to get a clear view for which issues a
patch has been submitted that require review (they are sort of
resolved). The issue is in between the state of 'in progress' and
'resolved', do people think it is a good idea to have an additional
state of 'patch proposed' (or a better name) so one can find out which
patches need to be reviewed?
-- 
Mark

Re: Patches for review

Posted by Mark Brouwer <ma...@marbro.org>.
Mark Brouwer wrote:

> I'm attaching a screendump of the allowed transitions so people can form
> an opinion about whether they like what they see. If we want to use this
> scheme it requires a schema update for the River issues so I need to
> arrange a backup first before changing it, so it might take a while.

The attachment seems to be removed from the issue, therefore I create a 
JIRA issue with the screendump, so you can have a look at 
https://issues.apache.org/jira/browse/RIVER-297
-- 
Mark

Re: Patches for review

Posted by Mark Brouwer <ma...@marbro.org>.
Peter Jones wrote:
> On Sun, Jun 01, 2008 at 11:16:33PM +0200, Mark Brouwer wrote:
>> BTW it is very hard currently to get a clear view for which issues a
>> patch has been submitted that require review (they are sort of
>> resolved). The issue is in between the state of 'in progress' and
>> 'resolved', do people think it is a good idea to have an additional
>> state of 'patch proposed' (or a better name) so one can find out
>> which patches need to be reviewed?
> 
> Seems useful to me.

To prevent from reinventing the wheel I had a look whether there is
already a customized workflow scheme that has an additional step for
submitting a patch. This scheme also prevents people from reopening a
closed issue (so they are forced to create a new issue) which seems
useful for me as well. I can't use it straight away because it has a
specific screen that incorporates fields that are not relevant to River,
but I can clone it and customize it to our needs.

I'm attaching a screendump of the allowed transitions so people can form
an opinion about whether they like what they see. If we want to use this
scheme it requires a schema update for the River issues so I need to
arrange a backup first before changing it, so it might take a while.
-- 
Mark



Re: Patches for review

Posted by Peter Jones <pe...@sun.com>.
On Sun, Jun 01, 2008 at 11:16:33PM +0200, Mark Brouwer wrote:
> BTW it is very hard currently to get a clear view for which issues a
> patch has been submitted that require review (they are sort of
> resolved). The issue is in between the state of 'in progress' and
> 'resolved', do people think it is a good idea to have an additional
> state of 'patch proposed' (or a better name) so one can find out
> which patches need to be reviewed?

Seems useful to me.

-- Peter

Re: Patches for review

Posted by Bob Scheifler <Bo...@Sun.COM>.
Mark Brouwer wrote:
>> The patch for RIVER-25 looks fine to me.  I'll note that a similar
>> problem exists with two lease WARNINGs in ProxyReg.register.
> 
> Yep, good point. Do you envision to display the Lease and 
> ServiceRegistration proxy only, or also the proxy of the lookup service 
> they originate from because people might not have implemented a 'proper' 
> toString() for these proxies. I created a new attachement for 
> https://issues.apache.org/jira/browse/RIVER-25 to reflect the change for 
> only showing the Lease and ServiceRegistration proxy.

What you've done is also what I would choose to log.  Patch looks fine to me.

- Bob

Re: Patches for review

Posted by Mark Brouwer <ma...@marbro.org>.
Bob Scheifler wrote:
> Mark Brouwer wrote:
>> Due to the large number of JIRA postings in a short timeframe, just a
>> note that patches for RIVER-22 and RIVER-25 have been posted.
> 
> The patch for RIVER-25 looks fine to me.  I'll note that a similar
> problem exists with two lease WARNINGs in ProxyReg.register.

Yep, good point. Do you envision to display the Lease and 
ServiceRegistration proxy only, or also the proxy of the lookup service 
they originate from because people might not have implemented a 'proper' 
toString() for these proxies. I created a new attachement for 
https://issues.apache.org/jira/browse/RIVER-25 to reflect the change for 
only showing the Lease and ServiceRegistration proxy.
-- 
Mark

Re: Patches for review

Posted by Bob Scheifler <Bo...@Sun.COM>.
Mark Brouwer wrote:
> Due to the large number of JIRA postings in a short timeframe, just a
> note that patches for RIVER-22 and RIVER-25 have been posted.

The patch for RIVER-25 looks fine to me.  I'll note that a similar
problem exists with two lease WARNINGs in ProxyReg.register.

- Bob