You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2020/09/04 03:44:32 UTC
[GitHub] [incubator-pegasus] hycdong opened a new pull request #594: Fix: fix db is not nullptr when release_db
hycdong opened a new pull request #594:
URL: https://github.com/apache/incubator-pegasus/pull/594
### What problem does this PR solve? <!--add issue link with summary if exists-->
### What is changed and how it works?
### Check List <!--REMOVE the items that are not applicable-->
Tests <!-- At least one of them must be included. -->
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
Code changes
- Has exported function/method change
- Has exported variable/fields change
- Has interface methods change
- Has persistent data change
Side effects
- Possible performance regression
- Increased code complexity
- Breaking backward compatibility
Related changes
- Need to cherry-pick to the release branch
- Need to update the documentation
- Need to be included in the release note
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] zhangyifan27 commented on pull request #594: fix: fix db is not nullptr when release_db
Posted by GitBox <gi...@apache.org>.
zhangyifan27 commented on pull request #594:
URL: https://github.com/apache/incubator-pegasus/pull/594#issuecomment-687999929
Could you also add a test wherein we close db twice to make sure the bug was fixed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] hycdong commented on pull request #594: fix: fix db is not nullptr when release_db
Posted by GitBox <gi...@apache.org>.
hycdong commented on pull request #594:
URL: https://github.com/apache/incubator-pegasus/pull/594#issuecomment-688677336
> Could you also add a test wherein we close db twice to make sure the bug was fixed?
Sure, I have added the unit test for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] levy5307 merged pull request #594: fix: fix db is not nullptr when release_db
Posted by GitBox <gi...@apache.org>.
levy5307 merged pull request #594:
URL: https://github.com/apache/incubator-pegasus/pull/594
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org