You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Kevin Clark (JIRA)" <ji...@apache.org> on 2008/06/26 02:24:45 UTC

[jira] Created: (THRIFT-61) C++ tests don't pass make check

C++ tests don't pass make check
-------------------------------

                 Key: THRIFT-61
                 URL: https://issues.apache.org/jira/browse/THRIFT-61
             Project: Thrift
          Issue Type: Bug
          Components: Library (C++)
            Reporter: Kevin Clark
         Attachments: cpp_output.txt

It fails fairly horribly. Output of make check attached in a sec...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (THRIFT-61) C++ tests don't pass make check

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Reiss resolved THRIFT-61.
-------------------------------

    Resolution: Fixed

> C++ tests don't pass make check
> -------------------------------
>
>                 Key: THRIFT-61
>                 URL: https://issues.apache.org/jira/browse/THRIFT-61
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (C++)
>            Reporter: Kevin Clark
>            Assignee: David Reiss
>         Attachments: cpp_output.txt
>
>
> It fails fairly horribly. Output of make check attached in a sec...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-61) C++ tests don't pass make check

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Reiss updated THRIFT-61:
------------------------------

    Patch Info: [Patch Available]

> C++ tests don't pass make check
> -------------------------------
>
>                 Key: THRIFT-61
>                 URL: https://issues.apache.org/jira/browse/THRIFT-61
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (C++)
>            Reporter: Kevin Clark
>            Assignee: David Reiss
>         Attachments: cpp_output.txt
>
>
> It fails fairly horribly. Output of make check attached in a sec...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-61) C++ tests don't pass make check

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608267#action_12608267 ] 

David Reiss commented on THRIFT-61:
-----------------------------------

Review please?

http://gitweb.thrift-rpc.org/?p=thrift.git;a=commitdiff;h=pri/dreiss/makecheck
sort-of-permalink: http://gitweb.thrift-rpc.org/?p=thrift.git;a=commitdiff;h=8ad8f99d248cb0b08fbcbaaa2f255360b7dffb53

> C++ tests don't pass make check
> -------------------------------
>
>                 Key: THRIFT-61
>                 URL: https://issues.apache.org/jira/browse/THRIFT-61
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (C++)
>            Reporter: Kevin Clark
>            Assignee: David Reiss
>         Attachments: cpp_output.txt
>
>
> It fails fairly horribly. Output of make check attached in a sec...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-61) C++ tests don't pass make check

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608249#action_12608249 ] 

David Reiss commented on THRIFT-61:
-----------------------------------

git bisect tracked this down to r665681.  The test is probably exercising the old and questionable behavior when flushing with nothing to write.  I'll try to clean up the test.

> C++ tests don't pass make check
> -------------------------------
>
>                 Key: THRIFT-61
>                 URL: https://issues.apache.org/jira/browse/THRIFT-61
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (C++)
>            Reporter: Kevin Clark
>            Assignee: David Reiss
>         Attachments: cpp_output.txt
>
>
> It fails fairly horribly. Output of make check attached in a sec...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-61) C++ tests don't pass make check

Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Clark updated THRIFT-61:
------------------------------

    Attachment: cpp_output.txt

The output of `make check`

> C++ tests don't pass make check
> -------------------------------
>
>                 Key: THRIFT-61
>                 URL: https://issues.apache.org/jira/browse/THRIFT-61
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (C++)
>            Reporter: Kevin Clark
>         Attachments: cpp_output.txt
>
>
> It fails fairly horribly. Output of make check attached in a sec...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (THRIFT-61) C++ tests don't pass make check

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Reiss reassigned THRIFT-61:
---------------------------------

    Assignee: David Reiss

> C++ tests don't pass make check
> -------------------------------
>
>                 Key: THRIFT-61
>                 URL: https://issues.apache.org/jira/browse/THRIFT-61
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (C++)
>            Reporter: Kevin Clark
>            Assignee: David Reiss
>         Attachments: cpp_output.txt
>
>
> It fails fairly horribly. Output of make check attached in a sec...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-61) C++ tests don't pass make check

Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608557#action_12608557 ] 

Kevin Clark commented on THRIFT-61:
-----------------------------------

Looks good to me.

> C++ tests don't pass make check
> -------------------------------
>
>                 Key: THRIFT-61
>                 URL: https://issues.apache.org/jira/browse/THRIFT-61
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (C++)
>            Reporter: Kevin Clark
>            Assignee: David Reiss
>         Attachments: cpp_output.txt
>
>
> It fails fairly horribly. Output of make check attached in a sec...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.