You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2022/02/03 17:20:20 UTC

[GitHub] [incubator-mxnet] bgawrych commented on a change in pull request #20864: [v1.9.x] Fix pip installation in containers

bgawrych commented on a change in pull request #20864:
URL: https://github.com/apache/incubator-mxnet/pull/20864#discussion_r798797687



##########
File path: ci/docker/install/ubuntu_python.sh
##########
@@ -32,5 +32,5 @@ ln -sf /usr/bin/python3.7 /usr/local/bin/python3
 
 # the version of the pip shipped with ubuntu may be too lower, install a recent version here
 wget -nv https://bootstrap.pypa.io/get-pip.py
-python3 get-pip.py
+/usr/local/bin/python3 get-pip.py
 pip3 install -r /work/requirements

Review comment:
       ```suggestion
   /usr/local/bin/python3 -m pip install -r /work/requirements
   ```

##########
File path: ci/docker/install/centos7_python.sh
##########
@@ -27,7 +27,7 @@ yum -y install https://repo.ius.io/ius-release-el7.rpm
 yum -y install python36u
 
 # Install PIP
-curl "https://bootstrap.pypa.io/get-pip.py" -o "get-pip.py"
+curl "https://bootstrap.pypa.io/pip/3.6/get-pip.py" -o "get-pip.py"
 python3.6 get-pip.py
 # Restrict numpy version to < 1.19.0 due to https://github.com/apache/incubator-mxnet/issues/18600
 pip3 install nose pylint 'numpy>1.16.0,<1.19.0' nose-timer requests 'h5py<3' scipy==1.2.3

Review comment:
       ```suggestion
   python3.6 -m pip install nose pylint 'numpy>1.16.0,<1.19.0' nose-timer requests 'h5py<3' scipy==1.2.3
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org