You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Pengzna (via GitHub)" <gi...@apache.org> on 2024/12/15 15:35:40 UTC
[PR] [Region Migration] Ignore exception when region migration considering unknown nodes. [iotdb]
Pengzna opened a new pull request, #14433:
URL: https://github.com/apache/iotdb/pull/14433
as title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Region Migration] Ignore exception when region migration considering unknown nodes. [iotdb]
Posted by "Pengzna (via GitHub)" <gi...@apache.org>.
Pengzna commented on code in PR #14433:
URL: https://github.com/apache/iotdb/pull/14433#discussion_r1887172821
##########
iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/pipe/PipeConsensus.java:
##########
@@ -407,6 +407,8 @@ public void removeRemotePeer(ConsensusGroupId groupId, Peer peer) throws Consens
LOGGER.info("[{}] wait {} to release all resource...", CLASS_NAME, peer);
impl.waitReleaseAllRegionRelatedResource(peer);
} catch (ConsensusGroupModifyPeerException e) {
+ LOGGER.error(
Review Comment:
@wangchao316 @OneSizeFitsQuorum thanks for advise! I will fix it in https://github.com/apache/iotdb/pull/14455, since this pr is deprecated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Region Migration] Ignore exception when region migration considering unknown nodes. [iotdb]
Posted by "wangchao316 (via GitHub)" <gi...@apache.org>.
wangchao316 commented on code in PR #14433:
URL: https://github.com/apache/iotdb/pull/14433#discussion_r1886017095
##########
iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/pipe/PipeConsensus.java:
##########
@@ -407,6 +407,8 @@ public void removeRemotePeer(ConsensusGroupId groupId, Peer peer) throws Consens
LOGGER.info("[{}] wait {} to release all resource...", CLASS_NAME, peer);
impl.waitReleaseAllRegionRelatedResource(peer);
} catch (ConsensusGroupModifyPeerException e) {
+ LOGGER.error(
Review Comment:
hi, why does remove this error log? if is a undeal exception, we can print warn.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Region Migration] Ignore exception when region migration considering unknown nodes. [iotdb]
Posted by "Pengzna (via GitHub)" <gi...@apache.org>.
Pengzna commented on PR #14433:
URL: https://github.com/apache/iotdb/pull/14433#issuecomment-2546145679
refer new pr https://github.com/apache/iotdb/pull/14455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Region Migration] Ignore exception when region migration considering unknown nodes. [iotdb]
Posted by "Pengzna (via GitHub)" <gi...@apache.org>.
Pengzna closed pull request #14433: [Region Migration] Ignore exception when region migration considering unknown nodes.
URL: https://github.com/apache/iotdb/pull/14433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Region Migration] Ignore exception when region migration considering unknown nodes. [iotdb]
Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum commented on code in PR #14433:
URL: https://github.com/apache/iotdb/pull/14433#discussion_r1886108763
##########
iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/pipe/PipeConsensusServerImpl.java:
##########
@@ -553,11 +553,20 @@ public void waitPeersToTargetPeerTransmissionCompleted(Peer targetPeer)
isTransmissionCompleted = true;
for (Peer peer : otherPeers) {
if (!peer.equals(targetPeer)) {
- isTransmissionCompleted &=
- isRemotePeerConsensusPipesTransmissionCompleted(
- peer,
- Collections.singletonList(new ConsensusPipeName(peer, targetPeer).toString()),
- isFirstCheckForOtherPeers);
+ try {
+ isTransmissionCompleted &=
+ isRemotePeerConsensusPipesTransmissionCompleted(
Review Comment:
do we need to add this for `waitTargetPeerToPeersTransmissionCompleted`?
##########
iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/pipe/PipeConsensus.java:
##########
@@ -407,6 +407,8 @@ public void removeRemotePeer(ConsensusGroupId groupId, Peer peer) throws Consens
LOGGER.info("[{}] wait {} to release all resource...", CLASS_NAME, peer);
impl.waitReleaseAllRegionRelatedResource(peer);
} catch (ConsensusGroupModifyPeerException e) {
+ LOGGER.error(
Review Comment:
use warn log is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org