You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Chen He (JIRA)" <ji...@apache.org> on 2014/11/12 20:03:35 UTC

[jira] [Commented] (YARN-2165) Timelineserver should validate that yarn.timeline-service.ttl-ms is greater than zero

    [ https://issues.apache.org/jira/browse/YARN-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14208475#comment-14208475 ] 

Chen He commented on YARN-2165:
-------------------------------

Hi [~zjshen], should the check be (<= 0) instead of (< 0) ? Since 0 ttl and ttlinterval have no real meanings.

> Timelineserver should validate that yarn.timeline-service.ttl-ms is greater than zero
> -------------------------------------------------------------------------------------
>
>                 Key: YARN-2165
>                 URL: https://issues.apache.org/jira/browse/YARN-2165
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Karam Singh
>         Attachments: YARN-2165.patch
>
>
> Timelineserver should validate that yarn.timeline-service.ttl-ms is greater than zero
> Currently if set yarn.timeline-service.ttl-ms=0 
> Or yarn.timeline-service.ttl-ms=-86400 
> Timeline server start successfully with complaining
> {code}
> 2014-06-15 14:52:16,562 INFO  timeline.LeveldbTimelineStore (LeveldbTimelineStore.java:<init>(247)) - Starting deletion thread with ttl -604800000 and cycle interval 300000
> {code}
> At starting timelinserver should that yarn.timeline-service-ttl-ms > 0
> otherwise specially for -ive value discard oldvalues timestamp will be set future value. Which may lead to inconsistancy in behavior 
> {code}
>     public void run() {
>       while (true) {
>         long timestamp = System.currentTimeMillis() - ttl;
>         try {
>           discardOldEntities(timestamp);
>           Thread.sleep(ttlInterval);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)