You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/06/03 03:44:42 UTC
[GitHub] [apisix-helm-chart] tao12345666333 opened a new pull request #89: chore: add externalTrafficPolicy for apisix gateway service
tao12345666333 opened a new pull request #89:
URL: https://github.com/apache/apisix-helm-chart/pull/89
Signed-off-by: Jintao Zhang <zh...@gmail.com>
closes #88
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers merged pull request #89: chore: add externalTrafficPolicy for apisix gateway service
Posted by GitBox <gi...@apache.org>.
tokers merged pull request #89:
URL: https://github.com/apache/apisix-helm-chart/pull/89
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #89: chore: add externalTrafficPolicy for apisix gateway service
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #89:
URL: https://github.com/apache/apisix-helm-chart/pull/89#discussion_r644697407
##########
File path: charts/apisix/templates/service-gateway.yaml
##########
@@ -28,6 +28,7 @@ metadata:
{{- include "apisix.labels" . | nindent 4 }}
spec:
type: {{ .Values.gateway.type }}
+ externalTrafficPolicy: {{ .Values.gateway.externalTrafficPolicy }}
Review comment:
Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on a change in pull request #89: chore: add externalTrafficPolicy for apisix gateway service
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on a change in pull request #89:
URL: https://github.com/apache/apisix-helm-chart/pull/89#discussion_r644465701
##########
File path: charts/apisix/templates/service-gateway.yaml
##########
@@ -28,6 +28,7 @@ metadata:
{{- include "apisix.labels" . | nindent 4 }}
spec:
type: {{ .Values.gateway.type }}
+ externalTrafficPolicy: {{ .Values.gateway.externalTrafficPolicy }}
Review comment:
Both `LoadBalancer` and `NodePort` are affected by this parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #89: chore: add externalTrafficPolicy for apisix gateway service
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #89:
URL: https://github.com/apache/apisix-helm-chart/pull/89#discussion_r644464736
##########
File path: charts/apisix/templates/service-gateway.yaml
##########
@@ -28,6 +28,7 @@ metadata:
{{- include "apisix.labels" . | nindent 4 }}
spec:
type: {{ .Values.gateway.type }}
+ externalTrafficPolicy: {{ .Values.gateway.externalTrafficPolicy }}
Review comment:
We can set this field only if the service type is `LoadBalancer`.
##########
File path: charts/apisix/templates/service-gateway.yaml
##########
@@ -28,6 +28,7 @@ metadata:
{{- include "apisix.labels" . | nindent 4 }}
spec:
type: {{ .Values.gateway.type }}
+ externalTrafficPolicy: {{ .Values.gateway.externalTrafficPolicy }}
Review comment:
Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #89: chore: add externalTrafficPolicy for apisix gateway service
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #89:
URL: https://github.com/apache/apisix-helm-chart/pull/89#discussion_r644464736
##########
File path: charts/apisix/templates/service-gateway.yaml
##########
@@ -28,6 +28,7 @@ metadata:
{{- include "apisix.labels" . | nindent 4 }}
spec:
type: {{ .Values.gateway.type }}
+ externalTrafficPolicy: {{ .Values.gateway.externalTrafficPolicy }}
Review comment:
We can set this field only if the service type is `LoadBalancer`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers merged pull request #89: chore: add externalTrafficPolicy for apisix gateway service
Posted by GitBox <gi...@apache.org>.
tokers merged pull request #89:
URL: https://github.com/apache/apisix-helm-chart/pull/89
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on a change in pull request #89: chore: add externalTrafficPolicy for apisix gateway service
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on a change in pull request #89:
URL: https://github.com/apache/apisix-helm-chart/pull/89#discussion_r644465701
##########
File path: charts/apisix/templates/service-gateway.yaml
##########
@@ -28,6 +28,7 @@ metadata:
{{- include "apisix.labels" . | nindent 4 }}
spec:
type: {{ .Values.gateway.type }}
+ externalTrafficPolicy: {{ .Values.gateway.externalTrafficPolicy }}
Review comment:
Both `LoadBalancer` and `NodePort` are affected by this parameter.
##########
File path: charts/apisix/templates/service-gateway.yaml
##########
@@ -28,6 +28,7 @@ metadata:
{{- include "apisix.labels" . | nindent 4 }}
spec:
type: {{ .Values.gateway.type }}
+ externalTrafficPolicy: {{ .Values.gateway.externalTrafficPolicy }}
Review comment:
Both `LoadBalancer` and `NodePort` are affected by this parameter.
I don’t think it is necessary to add judgment here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on a change in pull request #89: chore: add externalTrafficPolicy for apisix gateway service
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on a change in pull request #89:
URL: https://github.com/apache/apisix-helm-chart/pull/89#discussion_r644466194
##########
File path: charts/apisix/templates/service-gateway.yaml
##########
@@ -28,6 +28,7 @@ metadata:
{{- include "apisix.labels" . | nindent 4 }}
spec:
type: {{ .Values.gateway.type }}
+ externalTrafficPolicy: {{ .Values.gateway.externalTrafficPolicy }}
Review comment:
Both `LoadBalancer` and `NodePort` are affected by this parameter.
I don’t think it is necessary to add judgment here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org