You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/03/25 06:17:19 UTC

[GitHub] [incubator-mxnet] hcho3 commented on issue #14510: [TEST] upgrade dmlc-core

hcho3 commented on issue #14510: [TEST] upgrade dmlc-core
URL: https://github.com/apache/incubator-mxnet/pull/14510#issuecomment-476068467
 
 
   @eric-haibin-lin Platform-specific headers such as `Shlwapi.h` should have been wrapped with platform-specific macros (`_WIN32` etc). Does amalgamation not honor platform-specific macros?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services