You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Abhishek Rawat (Code Review)" <ge...@cloudera.org> on 2019/07/24 15:24:23 UTC
[Impala-ASF-CR] IMPALA-8641: Document compression codec zstd in Parquet
Abhishek Rawat has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13910
Change subject: IMPALA-8641: Document compression codec zstd in Parquet
......................................................................
IMPALA-8641: Document compression codec zstd in Parquet
Updated the documentation for query_option compression_codec to also
include zstd.
Change-Id: Id55dbc3297ec1560b04e4da2c93cc1aeb1e6fb2f
---
M docs/topics/impala_compression_codec.xml
M docs/topics/impala_parquet.xml
2 files changed, 24 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/13910/1
--
To view, visit http://gerrit.cloudera.org:8080/13910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id55dbc3297ec1560b04e4da2c93cc1aeb1e6fb2f
Gerrit-Change-Number: 13910
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8641: Document compression codec zstd in Parquet
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13910 )
Change subject: IMPALA-8641: Document compression codec zstd in Parquet
......................................................................
Patch Set 2:
I just noticed that we need to add zstd to the list of parquet codecs in topics/impala_file_formats.xml
--
To view, visit http://gerrit.cloudera.org:8080/13910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id55dbc3297ec1560b04e4da2c93cc1aeb1e6fb2f
Gerrit-Change-Number: 13910
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jul 2019 17:28:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8641: Document compression codec zstd in Parquet
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13910 )
Change subject: IMPALA-8641: Document compression codec zstd in Parquet
......................................................................
Patch Set 2:
Otherwise it looks good.
--
To view, visit http://gerrit.cloudera.org:8080/13910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id55dbc3297ec1560b04e4da2c93cc1aeb1e6fb2f
Gerrit-Change-Number: 13910
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jul 2019 17:28:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8641: Document compression codec zstd in Parquet
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13910 )
Change subject: IMPALA-8641: Document compression codec zstd in Parquet
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id55dbc3297ec1560b04e4da2c93cc1aeb1e6fb2f
Gerrit-Change-Number: 13910
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jul 2019 17:25:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8641: Document compression codec zstd in Parquet
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13910 )
Change subject: IMPALA-8641: Document compression codec zstd in Parquet
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/13910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id55dbc3297ec1560b04e4da2c93cc1aeb1e6fb2f
Gerrit-Change-Number: 13910
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Jul 2019 15:35:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8641: Document compression codec zstd in Parquet
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13910 )
Change subject: IMPALA-8641: Document compression codec zstd in Parquet
......................................................................
Patch Set 1:
Hi Abhishek,
I only gave +1 in case you want a review by Tim.
If you are confident with the content, I can give +2.
--
To view, visit http://gerrit.cloudera.org:8080/13910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id55dbc3297ec1560b04e4da2c93cc1aeb1e6fb2f
Gerrit-Change-Number: 13910
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Jul 2019 23:29:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8641: Document compression codec zstd in Parquet
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13910 )
Change subject: IMPALA-8641: Document compression codec zstd in Parquet
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/403/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/13910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id55dbc3297ec1560b04e4da2c93cc1aeb1e6fb2f
Gerrit-Change-Number: 13910
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Jul 2019 15:38:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8641: Document compression codec zstd in Parquet
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13910 )
Change subject: IMPALA-8641: Document compression codec zstd in Parquet
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/403/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/13910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id55dbc3297ec1560b04e4da2c93cc1aeb1e6fb2f
Gerrit-Change-Number: 13910
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Jul 2019 15:24:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8641: Document compression codec zstd in Parquet
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/13910 )
Change subject: IMPALA-8641: Document compression codec zstd in Parquet
......................................................................
Patch Set 1:
I think it is ok to commit this change. We are documenting the new codec and its usage (including the new compression level sub option). What's missing is to benchmark zstd's performance compared to other codecs. I think that can go in as part of lz4 documentation in 3.3.
--
To view, visit http://gerrit.cloudera.org:8080/13910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id55dbc3297ec1560b04e4da2c93cc1aeb1e6fb2f
Gerrit-Change-Number: 13910
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jul 2019 17:22:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8641: Document compression codec zstd in Parquet
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13910 )
Change subject: IMPALA-8641: Document compression codec zstd in Parquet
......................................................................
IMPALA-8641: Document compression codec zstd in Parquet
Updated the documentation for query_option compression_codec to also
include zstd.
Change-Id: Id55dbc3297ec1560b04e4da2c93cc1aeb1e6fb2f
Reviewed-on: http://gerrit.cloudera.org:8080/13910
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Alex Rodoni <ar...@cloudera.com>
---
M docs/topics/impala_compression_codec.xml
M docs/topics/impala_parquet.xml
2 files changed, 24 insertions(+), 7 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Alex Rodoni: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id55dbc3297ec1560b04e4da2c93cc1aeb1e6fb2f
Gerrit-Change-Number: 13910
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8641: Document compression codec zstd in Parquet
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13910 )
Change subject: IMPALA-8641: Document compression codec zstd in Parquet
......................................................................
Patch Set 2:
I will update impala_file_formats.xml in a separate patch.
--
To view, visit http://gerrit.cloudera.org:8080/13910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id55dbc3297ec1560b04e4da2c93cc1aeb1e6fb2f
Gerrit-Change-Number: 13910
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jul 2019 17:41:21 +0000
Gerrit-HasComments: No