You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/07/12 01:05:52 UTC
[GitHub] [cordova-android] erisu commented on a change in pull request #764:
feat: Build app bundles (.aab files)
erisu commented on a change in pull request #764: feat: Build app bundles (.aab files)
URL: https://github.com/apache/cordova-android/pull/764#discussion_r302795352
##########
File path: bin/templates/cordova/lib/builders/ProjectBuilder.js
##########
@@ -365,6 +382,31 @@ function findOutputApksHelper (dir, build_type, arch) {
return ret;
}
+function findOutputBundlesHelper (dir, build_type) {
+ var shellSilent = shell.config.silent;
+ shell.config.silent = true;
+
+ // list directory recursively
+ var ret = shell.ls('-R', dir).map(function (file) {
Review comment:
I just wanted to make a note that we been trying to drop `shelljs` as a dependency across repos when possible.
https://issues.apache.org/jira/browse/CB-14140
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org