You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "JFinis (via GitHub)" <gi...@apache.org> on 2023/10/08 13:02:25 UTC

[I] Implementation does not write `schema-id` into Manifest Avro headers [iceberg]

JFinis opened a new issue, #8745:
URL: https://github.com/apache/iceberg/issues/8745

   ### Apache Iceberg version
   
   1.3.1
   
   ### Query engine
   
   Spark
   
   ### Please describe the bug 🐞
   
   The spec mandates the field `schema-id` to be written into the Avro header of Manifest files (optional in v1, required in v2).
   
   Yet, the implementation neither writes the field in v1 nor v2.
   
   Also note that the field is somehow redundant, as the `schema-id`, if present, will also be in the `schema` itself, which is in the header as well.
   
   Suggestion: Remove mentioning of field completely from the spec. It's redundant and the implementation doesn't seem to write it anyway.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [I] Implementation does not write `schema-id` into Manifest Avro headers [iceberg]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on issue #8745:
URL: https://github.com/apache/iceberg/issues/8745#issuecomment-1783512462

   @JFinis I think this was in there so the schema didn't need to be deserialized. 
   
   > Suggestion: Remove mentioning of field completely from the spec. It's redundant and the implementation doesn't seem to write it anyway.
   
   WDYT of creating a PR, and also raising this on the dev list?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org