You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "advancedxy (via GitHub)" <gi...@apache.org> on 2023/03/10 10:15:49 UTC
[GitHub] [incubator-uniffle] advancedxy opened a new pull request, #707: [MINOR] fix: tempdir annotated variable should be referred in BeforeAll method
advancedxy opened a new pull request, #707:
URL: https://github.com/apache/incubator-uniffle/pull/707
### What changes were proposed in this pull request?
fix UTs
### Why are the changes needed?
Makes integration tests passed on local machines
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manually verified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on pull request #707: [MINOR] fix: tempdir annotated variable should be referred in BeforeAll method
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #707:
URL: https://github.com/apache/incubator-uniffle/pull/707#issuecomment-1463581939
@zuston this should also be applied for v0.7, one failed test is caused by this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #707: [MINOR] fix: tempdir annotated variable should be referred in BeforeAll method
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on code in PR #707:
URL: https://github.com/apache/incubator-uniffle/pull/707#discussion_r1132194195
##########
integration-test/common/src/test/java/org/apache/uniffle/test/DiskErrorToleranceTest.java:
##########
@@ -56,14 +56,15 @@
public class DiskErrorToleranceTest extends ShuffleReadWriteBase {
private ShuffleServerGrpcClient shuffleServerClient;
- @TempDir private static File serverTmpDir;
- private static File data1 = new File(serverTmpDir, "data1");
Review Comment:
serverTmpDir is injected after static variable initialization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen merged pull request #707: [MINOR] test: fix static field initialized before TempDir field injected
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen merged PR #707:
URL: https://github.com/apache/incubator-uniffle/pull/707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org