You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by as...@apache.org on 2026/10/09 02:15:31 UTC

(maka) 02/02: fix(release): accept the legacy worker name in Windows upgrade baselines

This is an automated email from the ASF dual-hosted git repository.

Astro-Han pushed a commit to branch ci/scheduled-workflows-skip-forks
in repository https://gitbox.apache.org/repos/asf/maka.git

commit 78c4a6f5c69af9a7ea353e96b0c3dd1bcefe9930
Author: AstroHan <le...@outlook.com>
AuthorDate: Fri Oct 9 12:15:24 2026 +1000

    fix(release): accept the legacy worker name in Windows upgrade baselines
    
    The pinned-version upgrade check verifies the previously released installer
    with the current resource list, which now demands
    `workers/filesystem-worker.mjs`. Releases built before the rename ship
    `filesystem-worker.js`, so the check failed on bytes that were correct when
    they shipped. Relax the requirement for the upgrade-baseline contract, like
    the other resources that newer builds added.
    
    Generated-by: Claude Code
---
 scripts/verify-packaged-app.mjs      | 4 +++-
 scripts/verify-packaged-app.test.mjs | 2 ++
 scripts/verify-windows-x64.mjs       | 1 +
 3 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/scripts/verify-packaged-app.mjs b/scripts/verify-packaged-app.mjs
index 800a89b94a..126a5d55c1 100644
--- a/scripts/verify-packaged-app.mjs
+++ b/scripts/verify-packaged-app.mjs
@@ -1053,13 +1053,15 @@ export async function assertPackagedResources(
     // Current Desktop builds ship the direct-peer Client addon beside its Rust
     // notices. Upgrade baselines may predate both resources.
     requireDirectPeerArtifact = true,
+    // Upgrade baselines may still ship the worker as `filesystem-worker.js`.
+    requireMjsFilesystemWorker = true,
   } = {},
 ) {
   const required = [
     'app.asar',
     'bundled-tools.json',
     ...(requireCanonicalIcon ? [join('assets', 'icon.png')] : []),
-    join('workers', 'filesystem-worker.mjs'),
+    ...(requireMjsFilesystemWorker ? [join('workers', 'filesystem-worker.mjs')] : []),
     ...(requireDirectPeerArtifact
       ? [
           join('runtime-host-peer', 'maka_runtime_host_peer.node'),
diff --git a/scripts/verify-packaged-app.test.mjs b/scripts/verify-packaged-app.test.mjs
index 1363556d59..fcba830a36 100644
--- a/scripts/verify-packaged-app.test.mjs
+++ b/scripts/verify-packaged-app.test.mjs
@@ -245,11 +245,13 @@ test('the upgrade baseline keeps the Git absence rule while relaxing newer resou
     requireCanonicalIcon: false,
     requireAppIconCatalog: false,
     requireDirectPeerArtifact: false,
+    requireMjsFilesystemWorker: false,
   });
 
   // A pinned baseline may predate any of these; none of them may be demanded
   // of bytes that were correct when they shipped.
   for (const path of [
+    join('resources', 'workers', 'filesystem-worker.mjs'),
     join('resources', 'assets', 'icon.png'),
     join('resources', 'licenses', 'maka', 'DISCLAIMER-WIP'),
     join('resources', 'runtime-host-peer', 'maka_runtime_host_peer.node'),
diff --git a/scripts/verify-windows-x64.mjs b/scripts/verify-windows-x64.mjs
index 9f14c0b333..9056114525 100644
--- a/scripts/verify-windows-x64.mjs
+++ b/scripts/verify-windows-x64.mjs
@@ -158,6 +158,7 @@ export async function verifyPackagedWindowsApp(
     requireCanonicalIcon: requiresCurrentContract,
     requireAppIconCatalog: requiresCurrentContract,
     requireDirectPeerArtifact: requiresCurrentContract,
+    requireMjsFilesystemWorker: requiresCurrentContract,
   });
   // The upgrade baseline is a build that shipped on its own channel, from its
   // own commit: its update feed and dependency closure are the ones that were


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org