You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/05/12 05:47:41 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #3699: sched/task: Remove stack argument from nxtask_init

xiaoxiang781216 opened a new pull request #3699:
URL: https://github.com/apache/incubator-nuttx/pull/3699


   ## Summary
   since nobody really pass the non-null stack pointer
   
   ## Impact
   Minor
   
   ## Testing
   Pass CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3699: sched/task: Remove stack argument from nxtask_init

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3699:
URL: https://github.com/apache/incubator-nuttx/pull/3699#issuecomment-840569458


   I will close this PR, and focus on to support the customize the stack pointer.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] davids5 commented on pull request #3699: sched/task: Remove stack argument from nxtask_init

Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3699:
URL: https://github.com/apache/incubator-nuttx/pull/3699#issuecomment-839661748


   @xiaoxiang781216 - This precludes a statically defined system. It should not brought in.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3699: sched/task: Remove stack argument from nxtask_init

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3699:
URL: https://github.com/apache/incubator-nuttx/pull/3699#issuecomment-839829190


   @davids5 I create a new PR https://github.com/apache/incubator-nuttx/pull/3703 to utilize the stack pointer fully. One of these two PR need to merge to avoid the partial solution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] davids5 commented on pull request #3699: sched/task: Remove stack argument from nxtask_init

Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3699:
URL: https://github.com/apache/incubator-nuttx/pull/3699#issuecomment-839915698


   @xiaoxiang781216 
   
   I thought the AP supported it. (living in the past I guess) 
   
   This type of a change should be discussed, I see the value but, this is just my opinion. Let's get some more feedback....
   @antmerlino @btashton @patacongo, @v01d ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #3699: sched/task: Remove stack argument from nxtask_init

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #3699:
URL: https://github.com/apache/incubator-nuttx/pull/3699#issuecomment-839709958


   > @xiaoxiang781216 - This precludes a statically defined system. It should not brought in.
   
   Here is my thought:
   
   1. All public API task_create/kthread_create/posix_spawn doesn't accept stack pointer as argument
   2. nxtask_init still do the dynamical allocation internally(e.g. task_group...)
   
   If the statical allocation is the target, the public API should accept the stack pointer at least. Do you think it's better to add stackaddr field in posix_a like this:
   ```
   struct posix_spawnattr_s
   {
     FAR void *stackaddr;           
     size_t    stacksize;
   };
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3699: sched/task: Remove stack argument from nxtask_init

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3699:
URL: https://github.com/apache/incubator-nuttx/pull/3699#issuecomment-839709958


   > @xiaoxiang781216 - This precludes a statically defined system. It should not brought in.
   
   Here is my thought:
   
   1. All public API task_create/kthread_create/posix_spawn doesn't accept stack pointer as argument
   2. nxtask_init still do the dynamical allocation internally(e.g. task_group...)
   
   If the statical allocation is the target, the public API should accept the stack pointer at least. Do you think it's better to add stackaddr field in posix_a like this:
   ```
   struct posix_spawnattr_s
   {
     FAR void *stackaddr;           
     size_t        stacksize;
   };
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 closed pull request #3699: sched/task: Remove stack argument from nxtask_init

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 closed pull request #3699:
URL: https://github.com/apache/incubator-nuttx/pull/3699


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org