You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by tamaashu <gi...@git.apache.org> on 2018/10/16 10:48:25 UTC

[GitHub] zookeeper pull request #671: ZOOKEEPER-3155: Remove Forrest XMLs and their b...

GitHub user tamaashu opened a pull request:

    https://github.com/apache/zookeeper/pull/671

    ZOOKEEPER-3155: Remove Forrest XMLs and their build process from the …

    …project
    
    In this commit I've removed the forrest XML files and their result from the repository.
    I've also removed the process to generate HTML and PDF files from the forrest files, since it's not needed anymore.
    
    It also effects the test-github-pr.sh and test-patch.sh, since we do have less parameters for them (FORREST_HOME).
    
    Change-Id: I30ecdb181f19eed05d86838b12c75e0c03e33710

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tamaashu/zookeeper ZOOKEEPER-3155

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/671.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #671
    
----
commit f467281da8072246ea3e51ac76f2e2144603fe2e
Author: Tamas Penzes <ta...@...>
Date:   2018-10-16T10:45:56Z

    ZOOKEEPER-3155: Remove Forrest XMLs and their build process from the project
    
    In this commit I've removed the forrest XML files and their result from the repository.
    I've also removed the process to generate HTML and PDF files from the forrest files, since it's not needed anymore.
    
    It also effects the test-github-pr.sh and test-patch.sh, since we do have less parameters for them (FORREST_HOME).
    
    Change-Id: I30ecdb181f19eed05d86838b12c75e0c03e33710

----


---

[GitHub] zookeeper issue #671: ZOOKEEPER-3155: Remove Forrest XMLs and their build pr...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:

    https://github.com/apache/zookeeper/pull/671
  
    
    Refer to this link for build results (access rights to CI server needed): 
    https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2481/



---

[GitHub] zookeeper issue #671: ZOOKEEPER-3155: Remove Forrest XMLs and their build pr...

Posted by tamaashu <gi...@git.apache.org>.
Github user tamaashu commented on the issue:

    https://github.com/apache/zookeeper/pull/671
  
    Hi @andor,...
    As I see I've got a green build. Could you please check if it's ready to commit? Thanks


---

[GitHub] zookeeper issue #671: ZOOKEEPER-3155: Remove Forrest XMLs and their build pr...

Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:

    https://github.com/apache/zookeeper/pull/671
  
    Sorry @tamaashu , I missed your comment.
    I'm @anmolnar btw, somebody has already stolen "andor". :)


---

[GitHub] zookeeper issue #671: ZOOKEEPER-3155: Remove Forrest XMLs and their build pr...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:

    https://github.com/apache/zookeeper/pull/671
  
    
    Refer to this link for build results (access rights to CI server needed): 
    https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2510/



---

[GitHub] zookeeper issue #671: ZOOKEEPER-3155: Remove Forrest XMLs and their build pr...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:

    https://github.com/apache/zookeeper/pull/671
  
    
    Refer to this link for build results (access rights to CI server needed): 
    https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2516/



---

[GitHub] zookeeper issue #671: ZOOKEEPER-3155: Remove Forrest XMLs and their build pr...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:

    https://github.com/apache/zookeeper/pull/671
  
    
    Refer to this link for build results (access rights to CI server needed): 
    https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2448/



---

[GitHub] zookeeper pull request #671: ZOOKEEPER-3155: Remove Forrest XMLs and their b...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zookeeper/pull/671


---

[GitHub] zookeeper issue #671: ZOOKEEPER-3155: Remove Forrest XMLs and their build pr...

Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:

    https://github.com/apache/zookeeper/pull/671
  
    Committed to master branch. Thanks @tamaashu !



---

[GitHub] zookeeper issue #671: ZOOKEEPER-3155: Remove Forrest XMLs and their build pr...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:

    https://github.com/apache/zookeeper/pull/671
  
    
    Refer to this link for build results (access rights to CI server needed): 
    https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2507/



---

[GitHub] zookeeper issue #671: ZOOKEEPER-3155: Remove Forrest XMLs and their build pr...

Posted by tamaashu <gi...@git.apache.org>.
Github user tamaashu commented on the issue:

    https://github.com/apache/zookeeper/pull/671
  
    retest this please


---

[GitHub] zookeeper issue #671: ZOOKEEPER-3155: Remove Forrest XMLs and their build pr...

Posted by tamaashu <gi...@git.apache.org>.
Github user tamaashu commented on the issue:

    https://github.com/apache/zookeeper/pull/671
  
    retest this please


---

[GitHub] zookeeper issue #671: ZOOKEEPER-3155: Remove Forrest XMLs and their build pr...

Posted by tamaashu <gi...@git.apache.org>.
Github user tamaashu commented on the issue:

    https://github.com/apache/zookeeper/pull/671
  
    retest this please


---

[GitHub] zookeeper issue #671: ZOOKEEPER-3155: Remove Forrest XMLs and their build pr...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:

    https://github.com/apache/zookeeper/pull/671
  
    
    Refer to this link for build results (access rights to CI server needed): 
    https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2472/



---

[GitHub] zookeeper issue #671: ZOOKEEPER-3155: Remove Forrest XMLs and their build pr...

Posted by tamaashu <gi...@git.apache.org>.
Github user tamaashu commented on the issue:

    https://github.com/apache/zookeeper/pull/671
  
    retest this please


---

[GitHub] zookeeper issue #671: ZOOKEEPER-3155: Remove Forrest XMLs and their build pr...

Posted by tamaashu <gi...@git.apache.org>.
Github user tamaashu commented on the issue:

    https://github.com/apache/zookeeper/pull/671
  
    rebased after last commit


---