svn commit: r1131729 - /incubator/mesos/trunk/src/nexus_exec.cpp

[be...@apache.org]

Author: benh
Date: Sun Jun  5 05:02:30 2011
New Revision: 1131729

URL: http://svn.apache.org/viewvc?rev=1131729&view=rev
Log:
When an executor dies it needs to killpg using 0 not getpid().

Modified:
    incubator/mesos/trunk/src/nexus_exec.cpp

Modified: incubator/mesos/trunk/src/nexus_exec.cpp
URL: http://svn.apache.org/viewvc/incubator/mesos/trunk/src/nexus_exec.cpp?rev=1131729&r1=1131728&r2=1131729&view=diff
==============================================================================
--- incubator/mesos/trunk/src/nexus_exec.cpp (original)
+++ incubator/mesos/trunk/src/nexus_exec.cpp Sun Jun  5 05:02:30 2011
@@ -55,6 +55,11 @@ protected:
     link(slave);
     send(slave, pack<E2S_REGISTER_EXECUTOR>(fid));
     while(true) {
+      // TODO(benh): Is there a better way to architect this code? In
+      // particular, if the executor blocks in a callback, we can't
+      // process any other messages. This is especially tricky if a
+      // slave dies since we won't handle the PROCESS_EXIT message in
+      // a timely manner (if at all).
       switch(receive()) {
         case S2E_REGISTER_REPLY: {
           string name;