You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by danobi <gi...@git.apache.org> on 2016/01/29 23:39:07 UTC
[GitHub] trafficserver pull request: TS-4165 Logging breaks if changing log...
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/446
TS-4165 Logging breaks if changing log format
TS wasn't calling `open_file()` on the LogFile it was trying
to rotate away. This was occurring when an existing log file's
formatting was changed in logs_xml.config and TS was restarted.
The result was TS not updating/creating the updated log file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/danobi/trafficserver TS-4165
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/446.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #446
----
commit b1a751e92bc223f620ab8746aeb29e607fc72a9d
Author: Daniel Xu <dl...@yahoo.com>
Date: 2016-01-29T22:38:11Z
TS-4165 Logging breaks if changing log format
TS wasn't calling `open_file()` on the LogFile it was trying
to rotate away. This was occurring when an existing log file's
formatting was changed in logs_xml.config and TS was restarted.
The result was TS not updating/creating the updated log file.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4165 Logging breaks if changing log...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/446
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4165 Logging breaks if changing log...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/446#discussion_r51428533
--- Diff: proxy/logging/LogObject.cc ---
@@ -1043,6 +1044,15 @@ LogObjectManager::_solve_filename_conflicts(LogObject *log_object, int maxConfli
return retVal;
}
+void
+LogObjectManager::_filename_resolution_abort(const char *filename)
+{
+ const char *msg = "Cannot roll log file %s to fix log "
+ "conflicts (filename or log format)";
+ Error(msg, filename);
--- End diff --
Can we get errno and strerr() in here as well? That would be good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---