You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/17 15:18:51 UTC
[GitHub] [flink] sjwiesman opened a new pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
sjwiesman opened a new pull request #13179:
URL: https://github.com/apache/flink/pull/13179
## What is the purpose of the change
Support full table scan of keys and namespaces from the state backend. All operations assume the calling code already knows what namespace they are interested in interacting with.
This is a prerequisite to support reading window operators with the state processor api because window panes are stored as additional namespace components.
## Brief change log
- Add method `<N> Stream<Tuple2<K, N>> getKeysAndNamespaces(String state)` to KeyedStateBackend and implementation for all state backends.
## Verifying this change
Added a new test to StateBackendTestBase along with some RocksDB specific tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (**yes** / no / don't know) Sort of, it touches the statebackends but not any existing code.
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-674957571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5622",
"triggerID" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"triggerType" : "PUSH"
}, {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5624",
"triggerID" : "675018285",
"triggerType" : "MANUAL"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5625",
"triggerID" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"triggerType" : "PUSH"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5630",
"triggerID" : "675090316",
"triggerType" : "MANUAL"
}, {
"hash" : "cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5632",
"triggerID" : "cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a",
"triggerType" : "PUSH"
}, {
"hash" : "04d5121a5f791efa1ae549ced4bd21e8b36bf19b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6026",
"triggerID" : "04d5121a5f791efa1ae549ced4bd21e8b36bf19b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04d5121a5f791efa1ae549ced4bd21e8b36bf19b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6026)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-674957571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5622",
"triggerID" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"triggerType" : "PUSH"
}, {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5624",
"triggerID" : "675018285",
"triggerType" : "MANUAL"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5625",
"triggerID" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"triggerType" : "PUSH"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5630",
"triggerID" : "675090316",
"triggerType" : "MANUAL"
}, {
"hash" : "cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5632",
"triggerID" : "cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a",
"triggerType" : "PUSH"
}, {
"hash" : "04d5121a5f791efa1ae549ced4bd21e8b36bf19b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6026",
"triggerID" : "04d5121a5f791efa1ae549ced4bd21e8b36bf19b",
"triggerType" : "PUSH"
}, {
"hash" : "f40dd9a3869f93be6185b98518b035548e42180e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6072",
"triggerID" : "f40dd9a3869f93be6185b98518b035548e42180e",
"triggerType" : "PUSH"
}, {
"hash" : "b985e226543345724377647b73884a2527ac5b30",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b985e226543345724377647b73884a2527ac5b30",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f40dd9a3869f93be6185b98518b035548e42180e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6072)
* b985e226543345724377647b73884a2527ac5b30 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-674957571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5622",
"triggerID" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"triggerType" : "PUSH"
}, {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5624",
"triggerID" : "675018285",
"triggerType" : "MANUAL"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5625",
"triggerID" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aebd0d34b4ced74ef21a7797234e47c3185ae08d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5625)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-674957571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5622",
"triggerID" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"triggerType" : "PUSH"
}, {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5624",
"triggerID" : "675018285",
"triggerType" : "MANUAL"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5625",
"triggerID" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"triggerType" : "PUSH"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5630",
"triggerID" : "675090316",
"triggerType" : "MANUAL"
}, {
"hash" : "cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5632",
"triggerID" : "cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a",
"triggerType" : "PUSH"
}, {
"hash" : "04d5121a5f791efa1ae549ced4bd21e8b36bf19b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6026",
"triggerID" : "04d5121a5f791efa1ae549ced4bd21e8b36bf19b",
"triggerType" : "PUSH"
}, {
"hash" : "f40dd9a3869f93be6185b98518b035548e42180e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6072",
"triggerID" : "f40dd9a3869f93be6185b98518b035548e42180e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f40dd9a3869f93be6185b98518b035548e42180e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6072)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman closed pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
sjwiesman closed pull request #13179:
URL: https://github.com/apache/flink/pull/13179
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a change in pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #13179:
URL: https://github.com/apache/flink/pull/13179#discussion_r483451813
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateBackend.java
##########
@@ -75,6 +76,13 @@
*/
<N> Stream<K> getKeys(String state, N namespace);
+ /**
+ * @return A stream of all keys for the given state and namespace. Modifications to the state during iterating
+ * over it keys are not supported.
+ * @param state State variable for which existing keys will be returned.
Review comment:
I think we'd better give explicit description that we cannot ensure the order of returned tuples, which means the tuples might be visited one by one across different namespaces. What do you think?
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/iterator/RocksStateKeysAndNamespaceIterator.java
##########
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.contrib.streaming.state.iterator;
+
+import org.apache.flink.api.common.typeutils.TypeSerializer;
+import org.apache.flink.api.java.tuple.Tuple2;
+import org.apache.flink.contrib.streaming.state.RocksDBKeySerializationUtils;
+import org.apache.flink.contrib.streaming.state.RocksIteratorWrapper;
+import org.apache.flink.core.memory.DataInputDeserializer;
+import org.apache.flink.util.FlinkRuntimeException;
+
+import javax.annotation.Nonnull;
+
+import java.io.IOException;
+import java.util.Iterator;
+import java.util.NoSuchElementException;
+
+/**
+ * Adapter class to bridge between {@link RocksIteratorWrapper} and {@link Iterator} to iterate over the keys
+ * and namespaces. This class is not thread safe.
+ *
+ * @param <K> the type of the iterated keys in RocksDB.
+ * @param <N> the type of the iterated namespaces in RocksDB.
+ */
+public class RocksStateKeysAndNamespaceIterator<K, N> implements Iterator<Tuple2<K, N>>, AutoCloseable {
Review comment:
I try to implement the abstract class and its extended class like:
~~~java
public abstract class AbstractRocksStateKeysIterator<K> implements AutoCloseable {
@Nonnull
protected final RocksIteratorWrapper iterator;
@Nonnull
protected final String state;
@Nonnull
protected final TypeSerializer<K> keySerializer;
protected final boolean ambiguousKeyPossible;
protected final int keyGroupPrefixBytes;
protected final DataInputDeserializer byteArrayDataInputView;
public AbstractRocksStateKeysIterator(
@Nonnull RocksIteratorWrapper iterator,
@Nonnull String state,
@Nonnull TypeSerializer<K> keySerializer,
int keyGroupPrefixBytes,
boolean ambiguousKeyPossible) {
this.iterator = iterator;
this.state = state;
this.keySerializer = keySerializer;
this.keyGroupPrefixBytes = keyGroupPrefixBytes;
this.ambiguousKeyPossible = ambiguousKeyPossible;
this.byteArrayDataInputView = new DataInputDeserializer();
}
protected K deserializeKey(byte[] keyBytes, DataInputDeserializer readView) throws IOException {
readView.setBuffer(keyBytes, keyGroupPrefixBytes, keyBytes.length - keyGroupPrefixBytes);
return RocksDBKeySerializationUtils.readKey(
keySerializer,
byteArrayDataInputView,
ambiguousKeyPossible);
}
@Override
public void close() {
iterator.close();
}
}
~~~
~~~java
public class RocksStateKeysIterator<K> extends AbstractRocksStateKeysIterator<K> implements Iterator<K> {
@Nonnull
private final byte[] namespaceBytes;
private K nextKey;
private K previousKey;
public RocksStateKeysIterator(
@Nonnull RocksIteratorWrapper iterator,
@Nonnull String state,
@Nonnull TypeSerializer<K> keySerializer,
int keyGroupPrefixBytes,
boolean ambiguousKeyPossible,
@Nonnull byte[] namespaceBytes) {
super(iterator, state, keySerializer, keyGroupPrefixBytes, ambiguousKeyPossible);
this.namespaceBytes = namespaceBytes;
this.nextKey = null;
this.previousKey = null;
}
@Override
public boolean hasNext() {
try {
while (nextKey == null && iterator.isValid()) {
final byte[] keyBytes = iterator.key();
final K currentKey = deserializeKey(keyBytes, byteArrayDataInputView);
final int namespaceByteStartPos = byteArrayDataInputView.getPosition();
if (isMatchingNameSpace(keyBytes, namespaceByteStartPos) && !Objects.equals(previousKey, currentKey)) {
previousKey = currentKey;
nextKey = currentKey;
}
iterator.next();
}
} catch (Exception e) {
throw new FlinkRuntimeException("Failed to access state [" + state + "]", e);
}
return nextKey != null;
}
@Override
public K next() {
if (!hasNext()) {
throw new NoSuchElementException("Failed to access state [" + state + "]");
}
K tmpKey = nextKey;
nextKey = null;
return tmpKey;
}
private boolean isMatchingNameSpace(@Nonnull byte[] key, int beginPos) {
final int namespaceBytesLength = namespaceBytes.length;
final int basicLength = namespaceBytesLength + beginPos;
if (key.length >= basicLength) {
for (int i = 0; i < namespaceBytesLength; ++i) {
if (key[beginPos + i] != namespaceBytes[i]) {
return false;
}
}
return true;
}
return false;
}
}
~~~
From my point of view, `RocksStateKeysAndNamespaceIterator` and `RocksStateKeysIterator` could share part of code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-674957571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5622",
"triggerID" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"triggerType" : "PUSH"
}, {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5624",
"triggerID" : "675018285",
"triggerType" : "MANUAL"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5622) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5624)
* aebd0d34b4ced74ef21a7797234e47c3185ae08d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-674957571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-674957571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5622",
"triggerID" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"triggerType" : "PUSH"
}, {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5624",
"triggerID" : "675018285",
"triggerType" : "MANUAL"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5625",
"triggerID" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"triggerType" : "PUSH"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5630",
"triggerID" : "675090316",
"triggerType" : "MANUAL"
}, {
"hash" : "cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5632",
"triggerID" : "cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a",
"triggerType" : "PUSH"
}, {
"hash" : "04d5121a5f791efa1ae549ced4bd21e8b36bf19b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6026",
"triggerID" : "04d5121a5f791efa1ae549ced4bd21e8b36bf19b",
"triggerType" : "PUSH"
}, {
"hash" : "f40dd9a3869f93be6185b98518b035548e42180e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f40dd9a3869f93be6185b98518b035548e42180e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04d5121a5f791efa1ae549ced4bd21e8b36bf19b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6026)
* f40dd9a3869f93be6185b98518b035548e42180e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-674957571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5622",
"triggerID" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5622)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-674957571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5622",
"triggerID" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"triggerType" : "PUSH"
}, {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5624",
"triggerID" : "675018285",
"triggerType" : "MANUAL"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5625",
"triggerID" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"triggerType" : "PUSH"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5630",
"triggerID" : "675090316",
"triggerType" : "MANUAL"
}, {
"hash" : "cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5632",
"triggerID" : "cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a",
"triggerType" : "PUSH"
}, {
"hash" : "04d5121a5f791efa1ae549ced4bd21e8b36bf19b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6026",
"triggerID" : "04d5121a5f791efa1ae549ced4bd21e8b36bf19b",
"triggerType" : "PUSH"
}, {
"hash" : "f40dd9a3869f93be6185b98518b035548e42180e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6072",
"triggerID" : "f40dd9a3869f93be6185b98518b035548e42180e",
"triggerType" : "PUSH"
}, {
"hash" : "b985e226543345724377647b73884a2527ac5b30",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6406",
"triggerID" : "b985e226543345724377647b73884a2527ac5b30",
"triggerType" : "PUSH"
}, {
"hash" : "32e7196f7eb7474982fa0e4e6489403316575099",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6454",
"triggerID" : "32e7196f7eb7474982fa0e4e6489403316575099",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 32e7196f7eb7474982fa0e4e6489403316575099 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6454)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-674957571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5622",
"triggerID" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"triggerType" : "PUSH"
}, {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5624",
"triggerID" : "675018285",
"triggerType" : "MANUAL"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5625",
"triggerID" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"triggerType" : "PUSH"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5630",
"triggerID" : "675090316",
"triggerType" : "MANUAL"
}, {
"hash" : "cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5632",
"triggerID" : "cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5632)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on a change in pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on a change in pull request #13179:
URL: https://github.com/apache/flink/pull/13179#discussion_r480295815
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/iterator/RocksStateKeysAndNamespaceIterator.java
##########
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.contrib.streaming.state.iterator;
+
+import org.apache.flink.api.common.typeutils.TypeSerializer;
+import org.apache.flink.api.java.tuple.Tuple2;
+import org.apache.flink.contrib.streaming.state.RocksDBKeySerializationUtils;
+import org.apache.flink.contrib.streaming.state.RocksIteratorWrapper;
+import org.apache.flink.core.memory.DataInputDeserializer;
+import org.apache.flink.util.FlinkRuntimeException;
+
+import javax.annotation.Nonnull;
+
+import java.io.IOException;
+import java.util.Iterator;
+import java.util.NoSuchElementException;
+
+/**
+ * Adapter class to bridge between {@link RocksIteratorWrapper} and {@link Iterator} to iterate over the keys
+ * and namespaces. This class is not thread safe.
+ *
+ * @param <K> the type of the iterated keys in RocksDB.
+ * @param <N> the type of the iterated namespaces in RocksDB.
+ */
+public class RocksStateKeysAndNamespaceIterator<K, N> implements Iterator<Tuple2<K, N>>, AutoCloseable {
Review comment:
-1 they are semantically similar but their `hasNext` methods are very different. In particular, the way they use the namespace bytes is quite different and I don't think a base class makes sense here. They both already share code via the `RocksDBSeySerializeionUtils` class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman closed pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
sjwiesman closed pull request #13179:
URL: https://github.com/apache/flink/pull/13179
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a change in pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #13179:
URL: https://github.com/apache/flink/pull/13179#discussion_r475395736
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateBackend.java
##########
@@ -75,6 +76,13 @@
*/
<N> Stream<K> getKeys(String state, N namespace);
+ /**
+ * @return A stream of all keys for the given state and namespace. Modifications to the state during iterating
+ * over it keys are not supported.
+ * @param state State variable for which existing keys will be returned.
Review comment:
From current implementation, we cannot ensure all entries within one namespace would be returned one by one, I think we'd better add some description here.
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/iterator/RocksStateKeysAndNamespaceIterator.java
##########
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.contrib.streaming.state.iterator;
+
+import org.apache.flink.api.common.typeutils.TypeSerializer;
+import org.apache.flink.api.java.tuple.Tuple2;
+import org.apache.flink.contrib.streaming.state.RocksDBKeySerializationUtils;
+import org.apache.flink.contrib.streaming.state.RocksIteratorWrapper;
+import org.apache.flink.core.memory.DataInputDeserializer;
+import org.apache.flink.util.FlinkRuntimeException;
+
+import javax.annotation.Nonnull;
+
+import java.io.IOException;
+import java.util.Iterator;
+import java.util.NoSuchElementException;
+
+/**
+ * Adapter class to bridge between {@link RocksIteratorWrapper} and {@link Iterator} to iterate over the keys
+ * and namespaces. This class is not thread safe.
+ *
+ * @param <K> the type of the iterated keys in RocksDB.
+ * @param <N> the type of the iterated namespaces in RocksDB.
+ */
+public class RocksStateKeysAndNamespaceIterator<K, N> implements Iterator<Tuple2<K, N>>, AutoCloseable {
Review comment:
I think this class could share some code with `RocksStateKeysIterator` as the main difference is they return different entry when calling `next()`
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/iterator/RocksStateKeysAndNamespaceIterator.java
##########
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.contrib.streaming.state.iterator;
+
+import org.apache.flink.api.common.typeutils.TypeSerializer;
+import org.apache.flink.api.java.tuple.Tuple2;
+import org.apache.flink.contrib.streaming.state.RocksDBKeySerializationUtils;
+import org.apache.flink.contrib.streaming.state.RocksIteratorWrapper;
+import org.apache.flink.core.memory.DataInputDeserializer;
+import org.apache.flink.util.FlinkRuntimeException;
+
+import javax.annotation.Nonnull;
+
+import java.io.IOException;
+import java.util.Iterator;
+import java.util.NoSuchElementException;
+
+/**
+ * Adapter class to bridge between {@link RocksIteratorWrapper} and {@link Iterator} to iterate over the keys
+ * and namespaces. This class is not thread safe.
+ *
+ * @param <K> the type of the iterated keys in RocksDB.
+ * @param <N> the type of the iterated namespaces in RocksDB.
+ */
+public class RocksStateKeysAndNamespaceIterator<K, N> implements Iterator<Tuple2<K, N>>, AutoCloseable {
+
+ @Nonnull
+ private final RocksIteratorWrapper iterator;
+
+ @Nonnull
+ private final String state;
+
+ @Nonnull
+ private final TypeSerializer<K> keySerializer;
+
+ @Nonnull
+ private final TypeSerializer<N> namespaceSerializer;
+
+ private final boolean ambiguousKeyPossible;
+ private final int keyGroupPrefixBytes;
+ private final DataInputDeserializer byteArrayDataInputView;
+ private Tuple2<K, N> nextKey;
+
+ public RocksStateKeysAndNamespaceIterator(
+ @Nonnull RocksIteratorWrapper iterator,
+ @Nonnull String state,
+ @Nonnull TypeSerializer<K> keySerializer,
+ @Nonnull TypeSerializer<N> namespaceSerializer, int keyGroupPrefixBytes,
Review comment:
This line should be separated.
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBRocksStateKeysAndNamespacesIteratorTest.java
##########
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.contrib.streaming.state;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.api.common.state.ValueState;
+import org.apache.flink.api.common.state.ValueStateDescriptor;
+import org.apache.flink.api.common.typeutils.TypeSerializer;
+import org.apache.flink.api.common.typeutils.base.IntSerializer;
+import org.apache.flink.api.common.typeutils.base.StringSerializer;
+import org.apache.flink.api.java.tuple.Tuple2;
+import org.apache.flink.contrib.streaming.state.iterator.RocksStateKeysAndNamespaceIterator;
+import org.apache.flink.core.fs.CloseableRegistry;
+import org.apache.flink.core.memory.DataOutputSerializer;
+import org.apache.flink.metrics.groups.UnregisteredMetricsGroup;
+import org.apache.flink.runtime.operators.testutils.MockEnvironment;
+import org.apache.flink.runtime.query.TaskKvStateRegistry;
+import org.apache.flink.runtime.state.KeyGroupRange;
+import org.apache.flink.runtime.state.filesystem.FsStateBackend;
+import org.apache.flink.runtime.state.ttl.TtlTimeProvider;
+
+import org.junit.Assert;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
+import org.rocksdb.ColumnFamilyHandle;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Comparator;
+import java.util.List;
+import java.util.function.Function;
+
+import static org.mockito.Mockito.mock;
+
+/**
+ * Tests for the RocksIteratorWrapper.
Review comment:
This doc should be updated.
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBRocksStateKeysAndNamespacesIteratorTest.java
##########
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.contrib.streaming.state;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.api.common.state.ValueState;
+import org.apache.flink.api.common.state.ValueStateDescriptor;
+import org.apache.flink.api.common.typeutils.TypeSerializer;
+import org.apache.flink.api.common.typeutils.base.IntSerializer;
+import org.apache.flink.api.common.typeutils.base.StringSerializer;
+import org.apache.flink.api.java.tuple.Tuple2;
+import org.apache.flink.contrib.streaming.state.iterator.RocksStateKeysAndNamespaceIterator;
+import org.apache.flink.core.fs.CloseableRegistry;
+import org.apache.flink.core.memory.DataOutputSerializer;
+import org.apache.flink.metrics.groups.UnregisteredMetricsGroup;
+import org.apache.flink.runtime.operators.testutils.MockEnvironment;
+import org.apache.flink.runtime.query.TaskKvStateRegistry;
+import org.apache.flink.runtime.state.KeyGroupRange;
+import org.apache.flink.runtime.state.filesystem.FsStateBackend;
+import org.apache.flink.runtime.state.ttl.TtlTimeProvider;
+
+import org.junit.Assert;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
+import org.rocksdb.ColumnFamilyHandle;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Comparator;
+import java.util.List;
+import java.util.function.Function;
+
+import static org.mockito.Mockito.mock;
+
+/**
+ * Tests for the RocksIteratorWrapper.
+ */
+public class RocksDBRocksStateKeysAndNamespacesIteratorTest {
Review comment:
I think this class might be able to share some code with `RocksDBRocksStateKeysIteratorTest`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-674957571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5622",
"triggerID" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"triggerType" : "PUSH"
}, {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5624",
"triggerID" : "675018285",
"triggerType" : "MANUAL"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5625",
"triggerID" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"triggerType" : "PUSH"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5630",
"triggerID" : "675090316",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* aebd0d34b4ced74ef21a7797234e47c3185ae08d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5625) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5630)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-674957571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5622",
"triggerID" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"triggerType" : "PUSH"
}, {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5624",
"triggerID" : "675018285",
"triggerType" : "MANUAL"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5625",
"triggerID" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"triggerType" : "PUSH"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5630",
"triggerID" : "675090316",
"triggerType" : "MANUAL"
}, {
"hash" : "cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5632",
"triggerID" : "cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a",
"triggerType" : "PUSH"
}, {
"hash" : "04d5121a5f791efa1ae549ced4bd21e8b36bf19b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "04d5121a5f791efa1ae549ced4bd21e8b36bf19b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5632)
* 04d5121a5f791efa1ae549ced4bd21e8b36bf19b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on a change in pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on a change in pull request #13179:
URL: https://github.com/apache/flink/pull/13179#discussion_r480317878
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBRocksStateKeysAndNamespacesIteratorTest.java
##########
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.contrib.streaming.state;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.api.common.state.ValueState;
+import org.apache.flink.api.common.state.ValueStateDescriptor;
+import org.apache.flink.api.common.typeutils.TypeSerializer;
+import org.apache.flink.api.common.typeutils.base.IntSerializer;
+import org.apache.flink.api.common.typeutils.base.StringSerializer;
+import org.apache.flink.api.java.tuple.Tuple2;
+import org.apache.flink.contrib.streaming.state.iterator.RocksStateKeysAndNamespaceIterator;
+import org.apache.flink.core.fs.CloseableRegistry;
+import org.apache.flink.core.memory.DataOutputSerializer;
+import org.apache.flink.metrics.groups.UnregisteredMetricsGroup;
+import org.apache.flink.runtime.operators.testutils.MockEnvironment;
+import org.apache.flink.runtime.query.TaskKvStateRegistry;
+import org.apache.flink.runtime.state.KeyGroupRange;
+import org.apache.flink.runtime.state.filesystem.FsStateBackend;
+import org.apache.flink.runtime.state.ttl.TtlTimeProvider;
+
+import org.junit.Assert;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
+import org.rocksdb.ColumnFamilyHandle;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Comparator;
+import java.util.List;
+import java.util.function.Function;
+
+import static org.mockito.Mockito.mock;
+
+/**
+ * Tests for the RocksIteratorWrapper.
+ */
+public class RocksDBRocksStateKeysAndNamespacesIteratorTest {
Review comment:
I pulled out some test utilities but these two are subtly different in ways that trying to really combine them turned into a mess.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-689689522
thank you for the detailed review. I've applied those suggestions and rebased my branch. If there aren't any other conerns I'll merge on green.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-674957571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5622",
"triggerID" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"triggerType" : "PUSH"
}, {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5624",
"triggerID" : "675018285",
"triggerType" : "MANUAL"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5625",
"triggerID" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"triggerType" : "PUSH"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5630",
"triggerID" : "675090316",
"triggerType" : "MANUAL"
}, {
"hash" : "cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5632",
"triggerID" : "cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a",
"triggerType" : "PUSH"
}, {
"hash" : "04d5121a5f791efa1ae549ced4bd21e8b36bf19b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6026",
"triggerID" : "04d5121a5f791efa1ae549ced4bd21e8b36bf19b",
"triggerType" : "PUSH"
}, {
"hash" : "f40dd9a3869f93be6185b98518b035548e42180e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6072",
"triggerID" : "f40dd9a3869f93be6185b98518b035548e42180e",
"triggerType" : "PUSH"
}, {
"hash" : "b985e226543345724377647b73884a2527ac5b30",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6406",
"triggerID" : "b985e226543345724377647b73884a2527ac5b30",
"triggerType" : "PUSH"
}, {
"hash" : "32e7196f7eb7474982fa0e4e6489403316575099",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6454",
"triggerID" : "32e7196f7eb7474982fa0e4e6489403316575099",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b985e226543345724377647b73884a2527ac5b30 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6406)
* 32e7196f7eb7474982fa0e4e6489403316575099 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6454)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-674957571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5622",
"triggerID" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"triggerType" : "PUSH"
}, {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5624",
"triggerID" : "675018285",
"triggerType" : "MANUAL"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5625",
"triggerID" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"triggerType" : "PUSH"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5630",
"triggerID" : "675090316",
"triggerType" : "MANUAL"
}, {
"hash" : "cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5632",
"triggerID" : "cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a",
"triggerType" : "PUSH"
}, {
"hash" : "04d5121a5f791efa1ae549ced4bd21e8b36bf19b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6026",
"triggerID" : "04d5121a5f791efa1ae549ced4bd21e8b36bf19b",
"triggerType" : "PUSH"
}, {
"hash" : "f40dd9a3869f93be6185b98518b035548e42180e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6072",
"triggerID" : "f40dd9a3869f93be6185b98518b035548e42180e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04d5121a5f791efa1ae549ced4bd21e8b36bf19b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6026)
* f40dd9a3869f93be6185b98518b035548e42180e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6072)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-674957571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5622",
"triggerID" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"triggerType" : "PUSH"
}, {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5624",
"triggerID" : "675018285",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5622) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5624)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman removed a comment on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
sjwiesman removed a comment on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-675018285
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-674957571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5622",
"triggerID" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"triggerType" : "PUSH"
}, {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5624",
"triggerID" : "675018285",
"triggerType" : "MANUAL"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5625",
"triggerID" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"triggerType" : "PUSH"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5630",
"triggerID" : "675090316",
"triggerType" : "MANUAL"
}, {
"hash" : "cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5632",
"triggerID" : "cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a",
"triggerType" : "PUSH"
}, {
"hash" : "04d5121a5f791efa1ae549ced4bd21e8b36bf19b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6026",
"triggerID" : "04d5121a5f791efa1ae549ced4bd21e8b36bf19b",
"triggerType" : "PUSH"
}, {
"hash" : "f40dd9a3869f93be6185b98518b035548e42180e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6072",
"triggerID" : "f40dd9a3869f93be6185b98518b035548e42180e",
"triggerType" : "PUSH"
}, {
"hash" : "b985e226543345724377647b73884a2527ac5b30",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6406",
"triggerID" : "b985e226543345724377647b73884a2527ac5b30",
"triggerType" : "PUSH"
}, {
"hash" : "32e7196f7eb7474982fa0e4e6489403316575099",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6454",
"triggerID" : "32e7196f7eb7474982fa0e4e6489403316575099",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 32e7196f7eb7474982fa0e4e6489403316575099 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6454)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-674957571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5622",
"triggerID" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"triggerType" : "PUSH"
}, {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5624",
"triggerID" : "675018285",
"triggerType" : "MANUAL"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5625",
"triggerID" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"triggerType" : "PUSH"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5630",
"triggerID" : "675090316",
"triggerType" : "MANUAL"
}, {
"hash" : "cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5632",
"triggerID" : "cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a",
"triggerType" : "PUSH"
}, {
"hash" : "04d5121a5f791efa1ae549ced4bd21e8b36bf19b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6026",
"triggerID" : "04d5121a5f791efa1ae549ced4bd21e8b36bf19b",
"triggerType" : "PUSH"
}, {
"hash" : "f40dd9a3869f93be6185b98518b035548e42180e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6072",
"triggerID" : "f40dd9a3869f93be6185b98518b035548e42180e",
"triggerType" : "PUSH"
}, {
"hash" : "b985e226543345724377647b73884a2527ac5b30",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6406",
"triggerID" : "b985e226543345724377647b73884a2527ac5b30",
"triggerType" : "PUSH"
}, {
"hash" : "32e7196f7eb7474982fa0e4e6489403316575099",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "32e7196f7eb7474982fa0e4e6489403316575099",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b985e226543345724377647b73884a2527ac5b30 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6406)
* 32e7196f7eb7474982fa0e4e6489403316575099 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-683960365
@Myasuka Thank you for taking a look, sorry for the delay I have been on vacation. Please take another look when you have time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-675018285
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-674957571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5622",
"triggerID" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"triggerType" : "PUSH"
}, {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5624",
"triggerID" : "675018285",
"triggerType" : "MANUAL"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5625",
"triggerID" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"triggerType" : "PUSH"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5630",
"triggerID" : "675090316",
"triggerType" : "MANUAL"
}, {
"hash" : "cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5632",
"triggerID" : "cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a",
"triggerType" : "PUSH"
}, {
"hash" : "04d5121a5f791efa1ae549ced4bd21e8b36bf19b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6026",
"triggerID" : "04d5121a5f791efa1ae549ced4bd21e8b36bf19b",
"triggerType" : "PUSH"
}, {
"hash" : "f40dd9a3869f93be6185b98518b035548e42180e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6072",
"triggerID" : "f40dd9a3869f93be6185b98518b035548e42180e",
"triggerType" : "PUSH"
}, {
"hash" : "b985e226543345724377647b73884a2527ac5b30",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6406",
"triggerID" : "b985e226543345724377647b73884a2527ac5b30",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b985e226543345724377647b73884a2527ac5b30 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6406)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-686698188
@myasuka please take another look when you have the time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-674944841
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1 (Mon Aug 17 15:20:42 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-675090316
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-674957571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5622",
"triggerID" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"triggerType" : "PUSH"
}, {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5624",
"triggerID" : "675018285",
"triggerType" : "MANUAL"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5625",
"triggerID" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"triggerType" : "PUSH"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5630",
"triggerID" : "675090316",
"triggerType" : "MANUAL"
}, {
"hash" : "cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5632",
"triggerID" : "cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aebd0d34b4ced74ef21a7797234e47c3185ae08d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5625) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5630)
* cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5632)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-674957571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5622",
"triggerID" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"triggerType" : "PUSH"
}, {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5624",
"triggerID" : "675018285",
"triggerType" : "MANUAL"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5625",
"triggerID" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"triggerType" : "PUSH"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5630",
"triggerID" : "675090316",
"triggerType" : "MANUAL"
}, {
"hash" : "cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aebd0d34b4ced74ef21a7797234e47c3185ae08d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5625) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5630)
* cab18cf6d00a0bb3af1e4bf6815e58c96359ee3a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-685113187
fixed the license issue, sorry about that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-674957571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5622",
"triggerID" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"triggerType" : "PUSH"
}, {
"hash" : "14f1835ca58d38bdb4d39bc9ff20f8d54e7090f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5624",
"triggerID" : "675018285",
"triggerType" : "MANUAL"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5625",
"triggerID" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"triggerType" : "PUSH"
}, {
"hash" : "aebd0d34b4ced74ef21a7797234e47c3185ae08d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5630",
"triggerID" : "675090316",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* aebd0d34b4ced74ef21a7797234e47c3185ae08d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5625) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5630)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on pull request #13179: [FLINK-18978][state-backends] Support full table scan of key and namespace from statebackend
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #13179:
URL: https://github.com/apache/flink/pull/13179#issuecomment-674944241
@carp84 Would you be able to help review this? Also @alpinegizmo fyi.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org