You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2025/03/13 10:55:55 UTC
svn commit: r1924362 - /pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/cos/TestCOSArray.java
Author: tilman
Date: Thu Mar 13 10:55:55 2025
New Revision: 1924362
URL: http://svn.apache.org/viewvc?rev=1924362&view=rev
Log:
PDFBOX-5660: remove unneeded cast
Modified:
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/cos/TestCOSArray.java
Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/cos/TestCOSArray.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/cos/TestCOSArray.java?rev=1924362&r1=1924361&r2=1924362&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/cos/TestCOSArray.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/cos/TestCOSArray.java Thu Mar 13 10:55:55 2025
@@ -24,7 +24,6 @@ import static org.junit.jupiter.api.Asse
import java.util.Arrays;
import java.util.List;
-import org.apache.pdfbox.pdmodel.common.COSObjectable;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
@@ -38,8 +37,7 @@ class TestCOSArray
{
COSArray cosArray = new COSArray();
assertEquals(0, cosArray.size());
- Assertions.assertThrows(NullPointerException.class, () -> new COSArray(
- (List<? extends COSObjectable>) null),
+ Assertions.assertThrows(NullPointerException.class, () -> new COSArray(null),
"Constructor should have thrown an exception");
cosArray = new COSArray(Arrays.asList(COSName.A, COSName.B, COSName.C));
@@ -114,7 +112,7 @@ class TestCOSArray
@Test
void testConvertFloat2COSStringAndBack()
{
- float[] floatArrayStart = { 1.0f, 0.1f, 0.02f };
+ float[] floatArrayStart = { 1f, 0.1f, 0.02f };
COSArray cosArray = new COSArray();
cosArray.setFloatArray(floatArrayStart);
@@ -125,14 +123,14 @@ class TestCOSArray
List<Float> cosNumberFloatList = cosArray.toCOSNumberFloatList();
assertEquals(3, cosNumberFloatList.size());
- assertEquals(1.0f, (float) cosNumberFloatList.get(0), 0);
- assertEquals(0.1f, (float) cosNumberFloatList.get(1), 0);
- assertEquals(0.02f, (float) cosNumberFloatList.get(2), 0);
+ assertEquals(1f, cosNumberFloatList.get(0), 0);
+ assertEquals(0.1f, cosNumberFloatList.get(1), 0);
+ assertEquals(0.02f, cosNumberFloatList.get(2), 0);
float[] floatArrayEnd = cosArray.toFloatArray();
- assertEquals(1.0f, (float) cosNumberFloatList.get(0), 0);
- assertEquals(0.1f, (float) cosNumberFloatList.get(1), 0);
- assertEquals(0.02f, (float) cosNumberFloatList.get(2), 0);
+ assertEquals(1f, cosNumberFloatList.get(0), 0);
+ assertEquals(0.1f, cosNumberFloatList.get(1), 0);
+ assertEquals(0.02f, cosNumberFloatList.get(2), 0);
assertArrayEquals(floatArrayStart, floatArrayEnd, 0);
// check arrays with null values
@@ -144,13 +142,13 @@ class TestCOSArray
cosNumberFloatList = cosArray.toCOSNumberFloatList();
assertEquals(3, cosNumberFloatList.size());
- assertEquals(1.0f, (float) cosNumberFloatList.get(0), 0);
+ assertEquals(1f, cosNumberFloatList.get(0), 0);
assertNull(cosNumberFloatList.get(1));
- assertEquals(0.02f, (float) cosNumberFloatList.get(2), 0);
+ assertEquals(0.02f, cosNumberFloatList.get(2), 0);
floatArrayEnd = cosArray.toFloatArray();
// due to the null value the second value of the array is set to 0
- assertArrayEquals(new float[] { 1.0f, 0f, 0.02f }, floatArrayEnd, 0);
+ assertArrayEquals(new float[] { 1f, 0, 0.02f }, floatArrayEnd, 0);
}