You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@tajo.apache.org by ykrips <gi...@git.apache.org> on 2014/10/04 09:02:01 UTC

[GitHub] tajo pull request: TAJO-1093: DateTimeFormat.to_char() is slower t...

GitHub user ykrips opened a pull request:

    https://github.com/apache/tajo/pull/177

    TAJO-1093: DateTimeFormat.to_char() is slower than SimpleDateFormat.form...

    String.format function internally uses the regular expression in its implementation. Using regular expression is expensive to use.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ykrips/tajo TAJO-1093

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/177.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #177
    
----
commit 127b2026b8b3cc010cce738706543f606dc69d18
Author: Jihun Kang <yk...@gmail.com>
Date:   2014-10-04T06:54:11Z

    TAJO-1093: DateTimeFormat.to_char() is slower than SimpleDateFormat.format()

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1093: DateTimeFormat.to_char() is slower t...

Posted by hyunsik <gi...@git.apache.org>.

Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/177#issuecomment-57924371
  
    Hi @ykrips,
    
    I read the patch in detail. It's very nice work. The result also significantly reduces the processing time. The following is my result of the test mentioned in the Jira.
    ```
    DateTimeFormat.to_char: 7044 ms (before)
    DateTimeFormat.to_char: 1139 ms (after)
    ```
    
    Here is my +1 for this patch. If there is no objection until tomorrow, I'll commit the patch to master branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1093: DateTimeFormat.to_char() is slower t...

Posted by hyunsik <gi...@git.apache.org>.

Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/177#issuecomment-57924612
  
    I verified 'mvn clean install'. All unit tests are passed. 
    
    Aside from this issue, we need to dig into the occasional test failure problem in TravisCI. I'll fix it soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1093: DateTimeFormat.to_char() is slower t...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/tajo/pull/177


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---