[GitHub] [superset] zhaoyongjie commented on a change in pull request #19366: fix: can't sync temporal flag on virtual table

[GitBox <gi...@apache.org>]

zhaoyongjie commented on a change in pull request #19366:
URL: https://github.com/apache/superset/pull/19366#discussion_r840256811



##########
File path: superset/result_set.py
##########
@@ -210,17 +210,17 @@ def size(self) -> int:
         return self.table.num_rows
 
     @property
-    def columns(self) -> List[Dict[str, Any]]:
+    def columns(self) -> List[ResultSetColumnType]:
         if not self.table.column_names:
             return []
 
         columns = []
         for col in self.table.schema:
             db_type_str = self.data_type(col.name, col.type)
-            column = {
+            column: ResultSetColumnType = {
                 "name": col.name,
                 "type": db_type_str,
-                "is_date": self.is_temporal(db_type_str),
+                "is_dttm": self.is_temporal(db_type_str),

Review comment:
       we should keep a consistent interface between the physical dataset and the virtual dataset.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org