You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by gi...@apache.org on 2018/12/20 17:39:44 UTC

[incubator-druid] branch master updated: Update two Javadocs to cite druid.generic.useDefaultValueForNull (#6760)

This is an automated email from the ASF dual-hosted git repository.

gian pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git


The following commit(s) were added to refs/heads/master by this push:
     new 9bbd992  Update two Javadocs to cite druid.generic.useDefaultValueForNull (#6760)
9bbd992 is described below

commit 9bbd9928857f673f87172838f71bf3fcf7ef90ad
Author: David Glasser <gl...@apollographql.com>
AuthorDate: Thu Dec 20 09:39:37 2018 -0800

    Update two Javadocs to cite druid.generic.useDefaultValueForNull (#6760)
    
    See #4349.
---
 core/src/main/java/org/apache/druid/data/input/Row.java  | 3 ++-
 core/src/main/java/org/apache/druid/data/input/Rows.java | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/core/src/main/java/org/apache/druid/data/input/Row.java b/core/src/main/java/org/apache/druid/data/input/Row.java
index c45dac2..2716a5b 100644
--- a/core/src/main/java/org/apache/druid/data/input/Row.java
+++ b/core/src/main/java/org/apache/druid/data/input/Row.java
@@ -78,7 +78,8 @@ public interface Row extends Comparable<Row>
   /**
    * Returns the metric column value for the given column name. This method is different from {@link #getRaw} in two
    * aspects:
-   *  1. If the column is absent in the row, numeric zero is returned, rather than null.
+   *  1. If the column is absent in the row, either numeric zero or null will be returned, depending on
+   *     the value of druid.generic.useDefaultValueForNull.
    *  2. If the column has string value, an attempt is made to parse this value as a number.
    */
   @Nullable
diff --git a/core/src/main/java/org/apache/druid/data/input/Rows.java b/core/src/main/java/org/apache/druid/data/input/Rows.java
index 55e060e..617905c 100644
--- a/core/src/main/java/org/apache/druid/data/input/Rows.java
+++ b/core/src/main/java/org/apache/druid/data/input/Rows.java
@@ -73,7 +73,8 @@ public class Rows
   }
 
   /**
-   * Convert an object to a number. Nulls are treated as zeroes.
+   * Convert an object to a number. Nulls are treated as zeroes unless
+   * druid.generic.useDefaultValueForNull is set to false.
    *
    * @param name       field name of the object being converted (may be used for exception messages)
    * @param inputValue the actual object being converted


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org