You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Kristine Hahn (Code Review)" <ge...@cloudera.org> on 2020/03/15 17:32:34 UTC
[Impala-ASF-CR] IMPALA-9467: [DOCS] live progress enabled by default in interactive mode
Kristine Hahn has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15442
Change subject: IMPALA-9467: [DOCS] live_progress enabled by default in interactive mode
......................................................................
IMPALA-9467: [DOCS] live_progress enabled by default in interactive mode
The following documents were impacted by the change:
- impala_common.xml, removed obsolete video, clarified
- impala_live_progress, revised to explain new behavior
- impala_shell_options.xml, removed --live_progress option
Change-Id: I94e624b7bb916ecb5aeb4f007c0610807f7b18cf
---
M docs/shared/impala_common.xml
M docs/topics/impala_live_progress.xml
M docs/topics/impala_shell_options.xml
3 files changed, 21 insertions(+), 48 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/15442/1
--
To view, visit http://gerrit.cloudera.org:8080/15442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I94e624b7bb916ecb5aeb4f007c0610807f7b18cf
Gerrit-Change-Number: 15442
Gerrit-PatchSet: 1
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
[Impala-ASF-CR] IMPALA-9467: [DOCS] live progress enabled by default in interactive mode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15442 )
Change subject: IMPALA-9467: [DOCS] live_progress enabled by default in interactive mode
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/557/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/15442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94e624b7bb916ecb5aeb4f007c0610807f7b18cf
Gerrit-Change-Number: 15442
Gerrit-PatchSet: 1
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 15 Mar 2020 17:32:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9467: [DOCS] live progress enabled by default in interactive mode
Posted by "Alice Fan (Code Review)" <ge...@cloudera.org>.
Alice Fan has posted comments on this change. ( http://gerrit.cloudera.org:8080/15442 )
Change subject: IMPALA-9467: [DOCS] live_progress enabled by default in interactive mode
......................................................................
Patch Set 1:
(4 comments)
Thanks very much for making the doc change. I left some comments to clarify. Please feel free to let me know if you have any questions.
http://gerrit.cloudera.org:8080/#/c/15442/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:
http://gerrit.cloudera.org:8080/#/c/15442/1/docs/shared/impala_common.xml@a1525
PS1, Line 1525:
:
Just for my curiosity, why do we want to remove the video? I mean It still shows the effect of live_progress and live_summary.
http://gerrit.cloudera.org:8080/#/c/15442/1/docs/topics/impala_live_progress.xml
File docs/topics/impala_live_progress.xml:
http://gerrit.cloudera.org:8080/#/c/15442/1/docs/topics/impala_live_progress.xml@a46
PS1, Line 46:
:
:
This paragraph is still true when live_progress = True. We may still want to keep it?
http://gerrit.cloudera.org:8080/#/c/15442/1/docs/topics/impala_live_progress.xml@51
PS1, Line 51: <p> You can turn off <codeph>LIVE_PROGRESS</codeph> within the shell
: using the <codeph>SET</codeph> command. </p>
IMPALA-9384 also proposed a new command line flag "--disable_live_progress". The flag allows users to disable live_progress in the runtime. e.g. run impala shell with "bin/impala-shell.sh --disable_live_progress" then live_progress will be disable in the interactive mode.
In addition, setting live_progress = false in the config file is another way to disable the shell option.
http://gerrit.cloudera.org:8080/#/c/15442/1/docs/topics/impala_shell_options.xml
File docs/topics/impala_shell_options.xml:
http://gerrit.cloudera.org:8080/#/c/15442/1/docs/topics/impala_shell_options.xml@a532
PS1, Line 532:
:
:
:
:
:
:
we still want to keep this right? as --live_progress is still an impala shell option. We may also want to add --disable_live_progress.
// for --live_progress
<row>
<entry>--live_progress</entry>
<entry>live_progress=true</entry>
<entry>Prints a progress bar .....</entry>
</row>
// for --disable_live_progress
<row>
<entry>--disable_live_progress</entry>
<entry>live_progress=false</entry>
<entry>A command line flag allows users to disable live_progress in the interactive mode.</entry>
</row>
--
To view, visit http://gerrit.cloudera.org:8080/15442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94e624b7bb916ecb5aeb4f007c0610807f7b18cf
Gerrit-Change-Number: 15442
Gerrit-PatchSet: 1
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Alice Fan <fa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Mar 2020 01:27:50 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9467: [DOCS] live progress enabled by default in interactive mode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15442 )
Change subject: IMPALA-9467: [DOCS] live_progress enabled by default in interactive mode
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/558/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/15442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94e624b7bb916ecb5aeb4f007c0610807f7b18cf
Gerrit-Change-Number: 15442
Gerrit-PatchSet: 2
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Alice Fan <fa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Mar 2020 15:53:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9467: [DOCS] live progress enabled by default in interactive mode
Posted by "Kristine Hahn (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Alice Fan, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15442
to look at the new patch set (#2).
Change subject: IMPALA-9467: [DOCS] live_progress enabled by default in interactive mode
......................................................................
IMPALA-9467: [DOCS] live_progress enabled by default in interactive mode
The following documents were impacted by the change:
- impala_live_progress.xml, revised to explain new behavior
- impala_shell_options.xml, added --disable_live_progress option
Change-Id: I94e624b7bb916ecb5aeb4f007c0610807f7b18cf
---
M docs/shared/impala_common.xml
M docs/topics/impala_live_progress.xml
M docs/topics/impala_shell_options.xml
3 files changed, 33 insertions(+), 32 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/15442/2
--
To view, visit http://gerrit.cloudera.org:8080/15442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I94e624b7bb916ecb5aeb4f007c0610807f7b18cf
Gerrit-Change-Number: 15442
Gerrit-PatchSet: 2
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Alice Fan <fa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9467: [DOCS] live progress enabled by default in interactive mode
Posted by "Alice Fan (Code Review)" <ge...@cloudera.org>.
Alice Fan has posted comments on this change. ( http://gerrit.cloudera.org:8080/15442 )
Change subject: IMPALA-9467: [DOCS] live_progress enabled by default in interactive mode
......................................................................
Patch Set 2: Code-Review+1
Thanks Kris!
--
To view, visit http://gerrit.cloudera.org:8080/15442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94e624b7bb916ecb5aeb4f007c0610807f7b18cf
Gerrit-Change-Number: 15442
Gerrit-PatchSet: 2
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Alice Fan <fa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Mar 2020 02:50:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9467: [DOCS] live progress enabled by default in interactive mode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15442 )
Change subject: IMPALA-9467: [DOCS] live_progress enabled by default in interactive mode
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/558/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/15442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94e624b7bb916ecb5aeb4f007c0610807f7b18cf
Gerrit-Change-Number: 15442
Gerrit-PatchSet: 2
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Alice Fan <fa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Mar 2020 15:45:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9467: [DOCS] live progress enabled by default in interactive mode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15442 )
Change subject: IMPALA-9467: [DOCS] live_progress enabled by default in interactive mode
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/557/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/15442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94e624b7bb916ecb5aeb4f007c0610807f7b18cf
Gerrit-Change-Number: 15442
Gerrit-PatchSet: 1
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 15 Mar 2020 17:40:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9467: [DOCS] live progress enabled by default in interactive mode
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15442 )
Change subject: IMPALA-9467: [DOCS] live_progress enabled by default in interactive mode
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94e624b7bb916ecb5aeb4f007c0610807f7b18cf
Gerrit-Change-Number: 15442
Gerrit-PatchSet: 2
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Alice Fan <fa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Mar 2020 16:57:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9467: [DOCS] live progress enabled by default in interactive mode
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15442 )
Change subject: IMPALA-9467: [DOCS] live_progress enabled by default in interactive mode
......................................................................
IMPALA-9467: [DOCS] live_progress enabled by default in interactive mode
The following documents were impacted by the change:
- impala_live_progress.xml, revised to explain new behavior
- impala_shell_options.xml, added --disable_live_progress option
Change-Id: I94e624b7bb916ecb5aeb4f007c0610807f7b18cf
Reviewed-on: http://gerrit.cloudera.org:8080/15442
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Alice Fan <fa...@gmail.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
---
M docs/shared/impala_common.xml
M docs/topics/impala_live_progress.xml
M docs/topics/impala_shell_options.xml
3 files changed, 33 insertions(+), 32 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Alice Fan: Looks good to me, but someone else must approve
Joe McDonnell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I94e624b7bb916ecb5aeb4f007c0610807f7b18cf
Gerrit-Change-Number: 15442
Gerrit-PatchSet: 3
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Alice Fan <fa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>