You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2021/06/08 11:50:57 UTC

[GitHub] [jackrabbit-filevault] kwin commented on a change in pull request #144: JCRVLT-526 improved support of legacy timezone designators "+hhmm"

kwin commented on a change in pull request #144:
URL: https://github.com/apache/jackrabbit-filevault/pull/144#discussion_r647363593



##########
File path: vault-core/src/test/java/org/apache/jackrabbit/vault/packaging/impl/PackagePropertiesImplTest.java
##########
@@ -93,9 +94,6 @@ public void testDateFormat() {
         checkDateParsing("2021-05-26T15:12:21.673+0200","2021-05-26T13:12:21.673Z");
         checkDateParsing("2021-05-26T15:12:21.673-0230","2021-05-26T17:42:21.673Z");
 
-        // missing timezone is treated as UTC. TODO is that right?
-        checkDateParsing("2021-05-26T15:12:21.673","2021-05-26T15:12:21.673Z");
-

Review comment:
       That date format was never produced and therefore is not supported (i.e. returns null)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org