You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2019/02/01 10:10:24 UTC
[GitHub] gemmellr commented on issue #30: PROTON-1998: Add SASL protocol
trace
gemmellr commented on issue #30: PROTON-1998: Add SASL protocol trace
URL: https://github.com/apache/qpid-proton-j/pull/30#issuecomment-459672396
Though I may have at the outset, I don't think I'd go this way with adjustment of TransportFrame at this point.
Given that the ProtocolTracer adds new methods to convey SASL details, and the non-tracer output specifically handles SASL output separately to begin with, I think the original bits are probably best left as is and simple addition made for the SASL bits (e.g a new package private transport log method). SASL frames also dont have a channel or payload so in this case a TransportFrame object is always just being used to carry the performative as the only detail, so the new ProtocolTracer methods could just pass that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org