You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Grant Ingersoll (JIRA)" <ji...@apache.org> on 2008/11/01 20:57:44 UTC

[jira] Created: (MAHOUT-93) BayesClassifier and CBayesClassifier are the same class

BayesClassifier and CBayesClassifier are the same class
-------------------------------------------------------

                 Key: MAHOUT-93
                 URL: https://issues.apache.org/jira/browse/MAHOUT-93
             Project: Mahout
          Issue Type: Improvement
          Components: Classification
            Reporter: Grant Ingersoll
            Assignee: Grant Ingersoll
            Priority: Minor
             Fix For: 0.1


There's no reason to have two classes w/ the exact same code: BayesClassifier and CBayesClassifier

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAHOUT-93) Refactor Bayes and CBayes to share more common code

Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAHOUT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll updated MAHOUT-93:
----------------------------------

    Description: 
There's no reason to have two classes w/ the exact same code: BayesClassifier and CBayesClassifier.

Also, there appears to be a fair amount of copied code between the two.  Let's refactor so that they share common code.

  was:There's no reason to have two classes w/ the exact same code: BayesClassifier and CBayesClassifier

        Summary: Refactor Bayes and CBayes to share more common code  (was: BayesClassifier and CBayesClassifier are the same class)

> Refactor Bayes and CBayes to share more common code
> ---------------------------------------------------
>
>                 Key: MAHOUT-93
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-93
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Classification
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>             Fix For: 0.1
>
>
> There's no reason to have two classes w/ the exact same code: BayesClassifier and CBayesClassifier.
> Also, there appears to be a fair amount of copied code between the two.  Let's refactor so that they share common code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAHOUT-93) Refactor Bayes and CBayes to share more common code

Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAHOUT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll updated MAHOUT-93:
----------------------------------

    Fix Version/s:     (was: 0.1)
                   0.2

> Refactor Bayes and CBayes to share more common code
> ---------------------------------------------------
>
>                 Key: MAHOUT-93
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-93
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Classification
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>             Fix For: 0.2
>
>
> There's no reason to have two classes w/ the exact same code: BayesClassifier and CBayesClassifier.
> Also, there appears to be a fair amount of copied code between the two implementations.  Let's refactor so that they share common code.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Work started: (MAHOUT-93) BayesClassifier and CBayesClassifier are the same class

Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAHOUT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on MAHOUT-93 started by Grant Ingersoll.

> BayesClassifier and CBayesClassifier are the same class
> -------------------------------------------------------
>
>                 Key: MAHOUT-93
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-93
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Classification
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>             Fix For: 0.1
>
>
> There's no reason to have two classes w/ the exact same code: BayesClassifier and CBayesClassifier

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (MAHOUT-93) Refactor Bayes and CBayes to share more common code

Posted by "Robin Anil (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAHOUT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robin Anil resolved MAHOUT-93.
------------------------------

    Resolution: Duplicate
      Assignee: Robin Anil  (was: Grant Ingersoll)

This has been taken care of by MAHOUT-124. 
The mentioned classes are now redundant. New API removed duplication of code

> Refactor Bayes and CBayes to share more common code
> ---------------------------------------------------
>
>                 Key: MAHOUT-93
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-93
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Classification
>            Reporter: Grant Ingersoll
>            Assignee: Robin Anil
>            Priority: Minor
>             Fix For: 0.2
>
>
> There's no reason to have two classes w/ the exact same code: BayesClassifier and CBayesClassifier.
> Also, there appears to be a fair amount of copied code between the two implementations.  Let's refactor so that they share common code.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAHOUT-93) Refactor Bayes and CBayes to share more common code

Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAHOUT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll updated MAHOUT-93:
----------------------------------

    Description: 
There's no reason to have two classes w/ the exact same code: BayesClassifier and CBayesClassifier.

Also, there appears to be a fair amount of copied code between the two implementations.  Let's refactor so that they share common code.  

  was:
There's no reason to have two classes w/ the exact same code: BayesClassifier and CBayesClassifier.

Also, there appears to be a fair amount of copied code between the two.  Let's refactor so that they share common code.


> Refactor Bayes and CBayes to share more common code
> ---------------------------------------------------
>
>                 Key: MAHOUT-93
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-93
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Classification
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>             Fix For: 0.1
>
>
> There's no reason to have two classes w/ the exact same code: BayesClassifier and CBayesClassifier.
> Also, there appears to be a fair amount of copied code between the two implementations.  Let's refactor so that they share common code.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAHOUT-93) Refactor Bayes and CBayes to share more common code

Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAHOUT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644538#action_12644538 ] 

Grant Ingersoll commented on MAHOUT-93:
---------------------------------------

I also don't understand why a lot of the Bayes code has references to CBayes.  Either it's copy and paste errors, or there is something really wrong.

> Refactor Bayes and CBayes to share more common code
> ---------------------------------------------------
>
>                 Key: MAHOUT-93
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-93
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Classification
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>             Fix For: 0.1
>
>
> There's no reason to have two classes w/ the exact same code: BayesClassifier and CBayesClassifier.
> Also, there appears to be a fair amount of copied code between the two implementations.  Let's refactor so that they share common code.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.